You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We wait for a new release of sqlalchemy-utils that includes our patch
Update sqlalchemy-utils
However, the fork above should work fine. I am committed to keeping the fork around, but not committed to keeping it up to date with sqlalchemy-utils, in case sqlalchemy-utils decides to reject our patch.
We will wait a while in hope that kvesteri/sqlalchemy-utils#426 will be accepted and merged. That way, this repository would not need to depend on a fork.
Just wondering about something. Since there is no migration in this PR, I assume that the underlying type of the encrypted columns does not change, the contents of those columns is just encrypted.
This led me to wonder what happens to existing data in those columns. I think the app will treat those data (which are in cleartext) as encrypted and try and decrypt them, which will give the wrong results (if it does not give an error).
We may need to write a script that will encrypt the data in those columns before deploying this PR. I'll come up with a minimal test case to determine if that needs to be done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #247
It appears however that EncryptedType from sqlalchemy-utils is broken for our environment (python3.7 & psycopg).
I spend some time fixing the bug and opening a PR with sqlalchemy-utils.
kvesteri/sqlalchemy-utils#426
Until this change gets merged, we need to specify the dependency in
requirements.txtasIf this is not desirable, I recommend that:
However, the fork above should work fine. I am committed to keeping the fork around, but not committed to keeping it up to date with sqlalchemy-utils, in case sqlalchemy-utils decides to reject our patch.