Skip to content

Commit

Permalink
bcachefs: Improve inode_to_text()
Browse files Browse the repository at this point in the history
Add line breaks - inode_to_text() is now much easier to read.

Signed-off-by: Kent Overstreet <[email protected]>
  • Loading branch information
Kent Overstreet committed Jan 21, 2024
1 parent d826cc5 commit 249f441
Showing 1 changed file with 18 additions and 7 deletions.
25 changes: 18 additions & 7 deletions fs/bcachefs/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -506,22 +506,33 @@ int bch2_inode_v3_invalid(struct bch_fs *c, struct bkey_s_c k,
static void __bch2_inode_unpacked_to_text(struct printbuf *out,
struct bch_inode_unpacked *inode)
{
prt_printf(out, "mode=%o ", inode->bi_mode);
printbuf_indent_add(out, 2);
prt_printf(out, "mode=%o", inode->bi_mode);
prt_newline(out);

prt_str(out, "flags=");
prt_bitflags(out, bch2_inode_flag_strs, inode->bi_flags & ((1U << 20) - 1));
prt_printf(out, " (%x)", inode->bi_flags);
prt_newline(out);

prt_printf(out, " journal_seq=%llu bi_size=%llu bi_sectors=%llu bi_version=%llu",
inode->bi_journal_seq,
inode->bi_size,
inode->bi_sectors,
inode->bi_version);
prt_printf(out, "journal_seq=%llu", inode->bi_journal_seq);
prt_newline(out);

prt_printf(out, "bi_size=%llu", inode->bi_size);
prt_newline(out);

prt_printf(out, "bi_sectors=%llu", inode->bi_sectors);
prt_newline(out);

prt_newline(out);
prt_printf(out, "bi_version=%llu", inode->bi_version);

#define x(_name, _bits) \
prt_printf(out, " "#_name "=%llu", (u64) inode->_name);
prt_printf(out, #_name "=%llu", (u64) inode->_name); \
prt_newline(out);
BCH_INODE_FIELDS_v3()
#undef x
printbuf_indent_sub(out, 2);
}

void bch2_inode_unpacked_to_text(struct printbuf *out, struct bch_inode_unpacked *inode)
Expand Down

0 comments on commit 249f441

Please sign in to comment.