Skip to content

Conversation

@n0nag0n
Copy link
Contributor

@n0nag0n n0nag0n commented May 30, 2024

Adminer is no longer maintained. AdminerEvo has been created to further maintain the Adminer project. I justed tested this myself on my machine pointing to AdminerEvo sources and it worked out of the box.

Also, thank you SO much for this repo! I wish this could be a default setting in Adminer cause I feel it's a bit silly to require a password on SQLite.

I also tested this on PHP 8.2 with no issues that I can see. There are issues with PHP 8.3 which is currently being talked about on AdminerEvo repo.

Adminer is no longer maintained. AdminerEvo has been created to further maintain the Adminer project. I justed tested this myself on my machine pointing to AdminerEvo sources and it worked out of the box.
@FrancoisCapon FrancoisCapon merged commit a2b6033 into FrancoisCapon:master Jul 16, 2024
@FrancoisCapon
Copy link
Owner

FrancoisCapon commented Jul 16, 2024

@n0nag0n

I wish this could be a default setting in Adminer cause I feel it's a bit silly to require a password on SQLite.

Yes and no, with path traversal an adminer user can, for example, access to all the databases of a shared web hosting.

I justed tested this myself on my machine pointing to AdminerEvo sources and it worked out of the box.
I also tested this on PHP 8.2 with no issues that I can see.

Yes, everything works well, but it still remain the warnings in PHP 8 when using SQL commands vrana/adminer#429 (I "transfer" my PR on AdminerEvo adminerevo/adminerevo#177).

Warning: Undefined property: stdClass::$orgtable in /var/www/html/adminer-4.8.4-sqlite-en.php on line 713
Warning: Undefined property: stdClass::$orgname in /var/www/html/adminer-4.8.4-sqlite-en.php on line 713
Warning: Undefined property: stdClass::$table in /var/www/html/adminer-4.8.4-sqlite-en.php on line 713

I added a test directory to try different versions of Adminer and PHP:

test$ ./test.sh 8.0 4.8.4 => warnings on SQL commands
test$ ./test.sh 7.4 4.8.4 => no warnings  on SQL commands

Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants