Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connecting to the Signal R hub introduced in this PR:
umbraco#17776
Discoveries while building this POC:
The created event should include the parent key. Or we need a separate event with this information
Currently, the created event includes the key of the newly created item. For the UI to update correctly, we also need to know the parent so we understand where to load from.
We need to include a "session key" to exclude SignalR events from the current user session.
We already have an internal event system that keeps track of UI updates within the current session. Updates will happen twice when SignalR events are also returned.
Server events should include the user key of the person who performed the action.
In the UI, we would like to display which user performed an action.