Remove duplicate of IR nodes inside the body#39
Merged
ForteScarlet merged 1 commit intoDec 21, 2023
Merged
Conversation
ForteScarlet
approved these changes
Dec 21, 2023
Owner
|
Wow! Awesome! Thank you, I'll try again from my local and get back to you with a reply from YouTrack! |
ForteScarlet
added a commit
that referenced
this pull request
Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found the problem you had with the local lambda creation.
You used
+expr, so, every node was added at least twice, and while the KLIB deserializer tried to create a function, it meat two variants of function that refer to the same symbol (this is an illegal state of the IR in Kotlin).I've fixed all the things, so it compiles both for JVM and JS