0.2.1 defaultProps migration introduces breaking change #562
Comments
|
Didn't realize there is already a pull-request discussing this issue: #559 |
|
Regardless of any PRs, this issue should exist. The usage of
|
|
Thanks, I'll take a look at this. |
|
Just released 0.2.2. Please give this a try. |
This was referenced Jun 29, 2024
This was referenced Sep 21, 2024
CrispyBaguette
pushed a commit
to CrispyBaguette/wasm-palette-converter
that referenced
this issue
Nov 8, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@fortawesome/react-fontawesome](https://github.com/FortAwesome/react-fontawesome) | dependencies | minor | [`^0.1.19` -> `^0.2.0`](https://renovatebot.com/diffs/npm/@fortawesome%2freact-fontawesome/0.1.19/0.2.2) | --- ### Release Notes <details> <summary>FortAwesome/react-fontawesome (@​fortawesome/react-fontawesome)</summary> ### [`v0.2.2`](https://github.com/FortAwesome/react-fontawesome/blob/HEAD/CHANGELOG.md#022---2024-05-22) [Compare Source](FortAwesome/react-fontawesome@0.2.1...0.2.2) ##### Fixed - Props with nullable/undefined values no longer throw an error [#​562](FortAwesome/react-fontawesome#562) [#​560](FortAwesome/react-fontawesome#560) *** ### [`v0.2.1`](https://github.com/FortAwesome/react-fontawesome/blob/HEAD/CHANGELOG.md#021---2024-05-16) [Compare Source](FortAwesome/react-fontawesome@0.2.0...0.2.1) ##### Changed - Remove defaultProps to be compatible with React 19 *** ### [`v0.2.0`](https://github.com/FortAwesome/react-fontawesome/blob/HEAD/CHANGELOG.md#020---2022-06-29) [Compare Source](FortAwesome/react-fontawesome@0.1.19...0.2.0) ##### Added - Support for React forwardRef if using React >= 16.3 **Previous [0.1.x change log available here](https://github.com/FortAwesome/react-fontawesome/blob/0.1.x/CHANGELOG.md)** </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xNDIuNSIsInVwZGF0ZWRJblZlciI6IjM4LjE0Mi41IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> Reviewed-on: https://gitea.bruyant.xyz/alexandre/PaletteSwitcher/pulls/44 Co-authored-by: Renovate <[email protected]> Co-committed-by: Renovate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Release 0.2.1 introduces bug where explicitly passing
undefinedas a className causes an errorReproducible test case
Codepen Demo
Expected behavior
This has potential to break existing code. Maybe revert and save for a major release?
This code works for version 0.2.0 but not on 0.2.1
<FontAwesomeIcon className={undefined} icon={faUser} />The text was updated successfully, but these errors were encountered: