Skip to content
This repository has been archived by the owner on Aug 13, 2022. It is now read-only.

Feature: ESM exports support #55

Merged
merged 38 commits into from
Jun 2, 2021
Merged

Conversation

ryan-roemer
Copy link
Member

@ryan-roemer ryan-roemer commented May 24, 2021

Work

Related follow-on work

Tasks

  • Handle https://unpkg.com/browse/[email protected]/package.json which currently blows things up.
  • Add documentation section discussing how it all works to README
  • Review and remove all TODOs
  • Review original ticket and ticket out future work / scenarios

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2021

Codecov Report

Merging #55 (d23ec56) into main (c91df16) will increase coverage by 0.07%.
The diff coverage is 98.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   98.41%   98.49%   +0.07%     
==========================================
  Files           5        6       +1     
  Lines         253      332      +79     
==========================================
+ Hits          249      327      +78     
- Misses          4        5       +1     
Impacted Files Coverage Δ
lib/trace.js 98.87% <97.26%> (-0.34%) ⬇️
lib/package.js 100.00% <100.00%> (ø)
lib/path.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c91df16...d23ec56. Read the comment docs.

@ryan-roemer ryan-roemer changed the title [WIP] Feature: ESM exports support Feature: ESM exports support May 26, 2021
@ryan-roemer
Copy link
Member Author

@bmathews @tptee -- This PR is ready for review / tire-kicking and should handle both of your respective project situations where ESM is giving you grief. Appreciate a review and any feedback!!!

@bkonkle
Copy link
Member

bkonkle commented May 28, 2021

Looks good in our project. Very minor size differences. 👍

@tptee
Copy link

tptee commented Jun 2, 2021

Works for our troublesome package now 🙌

@ryan-roemer ryan-roemer merged commit 2b08df2 into main Jun 2, 2021
@ryan-roemer ryan-roemer deleted the feature/modern-node-esm-all-exports branch June 2, 2021 19:55
@ryan-roemer
Copy link
Member Author

Released in [email protected]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Scenario: New Node.js ESM packages.
4 participants