Skip to content
This repository has been archived by the owner on Dec 15, 2018. It is now read-only.

Include hash in stringify-href to allow hashes in new tabs/windows #299

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Alex-Tideman
Copy link

@Alex-Tideman Alex-Tideman commented Dec 3, 2018

When there is a hash in the href and a user right-clicks to open the link in the new tab, the hash isn't included in the url. This can be very hard for users to find what they are looking for if you rely on hashes to jump to content in a new tab.

When there is a hash in the href and a user right-clicks to open the link in the new tab, the has isn't included in the url. This can be very annoying if you rely on hashes to jump to content in a new tab.
@Alex-Tideman Alex-Tideman changed the title Include hash in stringify-hash to allow hashes in new tabs/windows Include hash in stringify-href to allow hashes in new tabs/windows Dec 3, 2018
@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #299 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #299   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          28       28           
  Lines         362      362           
=======================================
  Hits          357      357           
  Misses          5        5
Impacted Files Coverage Δ
src/util/stringify-href.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff89966...863e87f. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #299 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #299   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          28       28           
  Lines         362      362           
=======================================
  Hits          357      357           
  Misses          5        5
Impacted Files Coverage Δ
src/util/stringify-href.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff89966...863e87f. Read the comment docs.

@Alex-Tideman
Copy link
Author

@tptee Any chance we could get this in soon?

@ryan-roemer
Copy link
Member

Hi @Alex-Tideman !

Thanks for the work! We're actually all super slammed this week and we're going to regroup next week for all things RLR-related.

@Alex-Tideman
Copy link
Author

👍 No worries, thanks for the response! Appreciate all the hard work you guys do.

@parkerziegler
Copy link
Contributor

Hey @Alex-Tideman! Thanks for the PR! As of December 10, 2018, this project is no longer under active maintenance and we will no longer be moving forward with issue requests. Thank you for helping to make redux-little-router better.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants