Skip to content
This repository has been archived by the owner on Dec 15, 2018. It is now read-only.

Add param and query examples to demo #245

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

stefvhuynh
Copy link
Contributor

No description provided.

@stefvhuynh stefvhuynh requested a review from tptee November 29, 2017 21:38
@codecov
Copy link

codecov bot commented Nov 29, 2017

Codecov Report

Merging #245 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #245   +/-   ##
=======================================
  Coverage   99.26%   99.26%           
=======================================
  Files          20       20           
  Lines         271      271           
=======================================
  Hits          269      269           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6165404...b6c72cb. Read the comment docs.

@ryan-roemer
Copy link
Member

@tptee -- Do you know what's up with bitHound - Dependencies — 11 failing dependencies.? The Details link goes to https://www.bithound.io/github/FormidableLabs/redux-little-router/b6c72cb2788456eee5176ceae14926e7d07ddf51/dependencies/npm#filter-failing-dep which doesn't tell us anything...

There are 15 outdated dependencies at https://www.bithound.io/github/FormidableLabs/redux-little-router/b6c72cb2788456eee5176ceae14926e7d07ddf51/dependencies/npm#filter-outdated-dep but is that supposed to fail CI for us?

Also, can you take a look at the substantive PR? Thanks!

Copy link
Member

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Let's wait on @tptee 's substantive review too.

@ryan-roemer
Copy link
Member

@tptee Bump

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants