Skip to content
This repository has been archived by the owner on Dec 15, 2018. It is now read-only.

Include POP action type as a public action type #218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pmeskers
Copy link

@pmeskers pmeskers commented Aug 2, 2017

This is a small PR which adds the POP (ROUTER_POP) action type to the public exports in src/index.js. Of all the types defined in src/types.js, this is the only one that was not included in the list of "public action types".

From what I can tell, it's quite useful since it's the only action which fires for both router induced back behavior (e.g., goBack()) and for browser induced back button (e.g., the browser's back button).

@codecov
Copy link

codecov bot commented Aug 2, 2017

Codecov Report

Merging #218 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #218   +/-   ##
=======================================
  Coverage   98.41%   98.41%           
=======================================
  Files          19       19           
  Lines         253      253           
=======================================
  Hits          249      249           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aa3297...34125ba. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant