This repository has been archived by the owner on Dec 15, 2018. It is now read-only.
From router.enhancer to router.connect #216
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
=========================================
- Coverage 98.41% 98.4% -0.02%
=========================================
Files 19 19
Lines 253 250 -3
=========================================
- Hits 249 246 -3
Misses 4 4
Continue to review full report at Codecov.
|
villesau
force-pushed
the
get-rid-of-enhancer-pattern
branch
from
e7badbf to
8d9bf2f
Compare
villesau
changed the title
|
That sounds good. I also suspect the enhancer is the reason the redux devtools don't work any more for me. |
|
@gouegd redux devtools seems to be working OK for me |
|
For me too now - or sometimes it gets stuck and I just reopen the debug tools. I don't think this comes from RFR at this point. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #215
This PR:
As the stores
matchRoutefunction is not used anywhere, it's possible to get rid of it. When getting rid of it, the enhancer actually anymore just connects to the store so it shouldn't anymore be in the enhancer chain.