This repository has been archived by the owner on Dec 15, 2018. It is now read-only.
Alternative combination of top-level reducer (docs) #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems likely that most people will have an app reducer already combined at the point at which the store is created, having imported their top-levelprecombined reducer. Happy to reformulate this into an alternate section as opposed to a comment or whatever you suggest. I think the current example will likely lead people to introducing an extra level into their reducers that they did not want.
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
=======================================
Coverage 99.06% 99.06%
=======================================
Files 19 19
Lines 215 215
=======================================
Hits 213 213
Misses 2 2Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems likely that most people will have an app reducer already combined at the point at which the store is created, having imported their top-level precombined reducer.
Happy to reformulate this into an alternate section as opposed to a comment or whatever you suggest. I think the current example will likely lead people to introducing an extra level into their reducers that they did not want.
I can't think of a cleaner way than this right now, but you get the idea.