Skip to content
This repository has been archived by the owner on Dec 15, 2018. It is now read-only.

RelativeFragment using _only_ withConditions never renders #115

Closed
mmcgahan opened this issue Oct 28, 2016 · 2 comments
Closed

RelativeFragment using _only_ withConditions never renders #115

mmcgahan opened this issue Oct 28, 2016 · 2 comments
Labels

Comments

@mmcgahan
Copy link
Contributor

It looks like you cannot use withConditions logic with <RelativeFragment> without also including forRoute - the store.matchWildcardRoute will always return null, which means this line always results in a null render.

The 'fix' is to use AbsoluteFragment instead of RelativeFragment, but it would be nice if I could just use one kind of fragment across my entire app without having to worry about different behavior outside of how forRoute is interpreted.

It would be worth adding a parallel test that uses RelativeFragment for both of these test cases, unless RelativeFragment should never be used in this way.

kdojeteri pushed a commit to kdojeteri/redux-little-router that referenced this issue Jan 15, 2017
For relative fragment default forRoute to parent route and hopefully fix FormidableLabs#115
@tptee tptee added the bug label Mar 23, 2017
@tptee
Copy link
Contributor

tptee commented Jun 11, 2017

I have a fix upcoming for this in the next major version 🎉

@tptee
Copy link
Contributor

tptee commented Jun 22, 2017

This is done in v14.0.0-0

@tptee tptee closed this as completed Jun 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants