-
Notifications
You must be signed in to change notification settings - Fork 258
Set up Formideploy for Docusarus site #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
||
| export const noInlineExample = ` | ||
| const Counter = () => { | ||
| type Props = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just adding Typescript-based sample code to our docs.
gksander
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just want to verify we've got the build output and baseUrl configured properly
| // Build output directory. | ||
| // Docusaurus defaults to `build`. | ||
| // We use `docusaurus build --out-dir build/open-source/docusaurus` to build intermediate real dirs. | ||
| dir: "build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in package.json, for the build script, you'll want to update the output dir. And then also check the baseUrl in docusaurus config to make sure it matches. Groqd should have an example of those two things (reviewing from mobile right now)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for catching that. Yeah, the paths were off. I believe I pushed the correct URLs now that mirror our configuration for groqd.
ryan-roemer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
gksander
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⛹️♂️
Sets up the pipeline to deploy our docs site to
formidable.com/open-source/react-live