Skip to content

Conversation

@carloskelly13
Copy link
Contributor

Sets up the pipeline to deploy our docs site to formidable.com/open-source/react-live

@vercel
Copy link

vercel bot commented Mar 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-live ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 30, 2023 at 7:57PM (UTC)

@carloskelly13 carloskelly13 marked this pull request as ready for review March 30, 2023 17:31

export const noInlineExample = `
const Counter = () => {
type Props = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just adding Typescript-based sample code to our docs.

Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just want to verify we've got the build output and baseUrl configured properly

// Build output directory.
// Docusaurus defaults to `build`.
// We use `docusaurus build --out-dir build/open-source/docusaurus` to build intermediate real dirs.
dir: "build",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in package.json, for the build script, you'll want to update the output dir. And then also check the baseUrl in docusaurus config to make sure it matches. Groqd should have an example of those two things (reviewing from mobile right now)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching that. Yeah, the paths were off. I believe I pushed the correct URLs now that mirror our configuration for groqd.

Copy link
Member

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛹️‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants