Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing peer dependencies #180

Closed
wants to merge 1 commit into from

Conversation

arcanis
Copy link

@arcanis arcanis commented Jan 6, 2020

Missing peer dependencies cause package managers to incorrectly hoist packages, causing subtle breakages particularly hard to debug.

@arcanis
Copy link
Author

arcanis commented Nov 19, 2024

Out of curiosity, why did this get closed?

@carbonrobot
Copy link
Contributor

carbonrobot commented Nov 19, 2024

@arcanis The package.json for the module already contains peerDeps. The file being updated in this PR is the root monorepo package.json and is unrelated to the module itself, so it doesn't need peerDeps.

Since this was opened several years ago, it was likely resolved by a different developer over time, I'm just cleaning up the stale issues and PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants