-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update types to use generics & add a TS test for react-redux #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
our goal here is to have a failing test, just like #61
9393d7a
to
ffeeaf0
Compare
ffeeaf0
to
58cf873
Compare
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=========================================
Coverage ? 98.21%
=========================================
Files ? 1
Lines ? 56
Branches ? 0
=========================================
Hits ? 55
Misses ? 1
Partials ? 0
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one thing i missed in my previous review. Also, since i went ahead and corrected the types, we should probably include that in the title of the PR, so we don't forget that we changed the types - a big deal, as it changes the library's API.
Description
Rel: #69
This PR introduces a test for react-redux's
useSelector
hook to access state. Ideally, we should also confirm the # of overlapping values to make sure we're using the hook as expected, but I didn't want to get too into the weeds of wrapping another test around this one.Would appreciate feedback / input on how I can enhance this test.
Checklist:
test-ts-defs
andtest-ts-usage
The bundle size badge has been updated to reflect the new sizeN/A, still at 369