Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix react-native bug for DOM "Element" checking #39

Merged
merged 2 commits into from
Nov 9, 2018
Merged

fix react-native bug for DOM "Element" checking #39

merged 2 commits into from
Nov 9, 2018

Conversation

chrisbolin
Copy link
Contributor

Fix for #38

@chrisbolin chrisbolin mentioned this pull request Nov 9, 2018
Closed
@pgom
Copy link

pgom commented Nov 9, 2018

💪

@chrisbolin
Copy link
Contributor Author

Fix doesn't work on IE. I'm guessing Element is not a function on IE. It's probably easier to test on AppVeyor in CI than to get a VM with IE (not Edge!) up and running. Will do this now

@pgom
Copy link

pgom commented Nov 9, 2018 •
edited
Loading

What about just checking if typeof(Element) != undefined?

@chrisbolin
Copy link
Contributor Author

nice when a theory works out. So Element is typeof "object" in IE. Will change this and retest

@chrisbolin chrisbolin merged commit c0c1177 into master Nov 9, 2018
@chrisbolin chrisbolin deleted the bugfix-react-native branch December 19, 2019 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisbolin @pgom