This repository has been archived by the owner on Mar 4, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 149
feat(#64) added multiple aggregate levels #66
Merged
jasonwilson
merged 21 commits into
FormidableLabs:master
from
mscottx88:features/graph-units-of-time
Aug 8, 2017
Merged
Changes from 19 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
f5666af
feat(#64) added multiple aggregate levels
22bc27a
fix(#64) remove vscode file first, then gitignore it
mscottx88 bdd3adf
fix(#64) gitignore vs code
mscottx88 e74e992
test(#64) added unit tests for MetricsProvider
64e7805
test(#64) removed gulp, removed duplicate setup
mscottx88 89a6fa2
test(#64) removed unnecessary done()
mscottx88 07871d1
fix(#64) test use sandbox stub
mscottx88 f3b8f2c
fix(#64) cross-platform fix to coverage
mscottx88 6dce469
chore(#64) simplified aggregation
mscottx88 7b373a1
chore(#64) converted to inline aggregation
mscottx88 6dd1f3b
test(#64) 100% code coverage MetricsProvider
mscottx88 939ba75
docs(#64) bumped version and added changelog entry
mscottx88 403853a
fix(#64) corrections for code review
mscottx88 b7eec6c
docs(#64) added notes to Changelog
mscottx88 ae31391
fix(#64) no more forced layouts
mscottx88 1b61876
fix(#64) improved time labels
mscottx88 d749914
fix(#64) getTimeIndexLabel is not a member function
mscottx88 07ddccb
fix(#64) lodash has padStart
mscottx88 dbd091e
fix(#64) memory guage view frozen
mscottx88 b3f7319
docs(#64) separate MD for aggregation
20c542f
docs(#64) correct PR ref
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
/node_modules | ||
npm-debug.log | ||
coverage | ||
.vscode |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
"use strict"; | ||
|
||
// these define the time levels that data will be aggregated into | ||
// each number is in milliseconds | ||
// | ||
// since these are used as object keys, they are strings | ||
// | ||
// For example, 5000 = 5s and means that one of the aggregate levels | ||
// will be at 5s increments of time | ||
// | ||
// 300000 = 30s and the corresponding zoom will show 30s aggregates | ||
var AGGREGATE_TIME_LEVELS = [ | ||
"5000", | ||
"10000", | ||
"15000", | ||
"30000", | ||
"60000", | ||
"300000", | ||
"600000", | ||
"900000", | ||
"1800000", | ||
"3600000" | ||
]; | ||
|
||
// this array object is used to reduce ms to its highest human-readable form | ||
// see lib/providers/metrics-provider.js::getTimeIndexLabel | ||
var TIME_SCALES = [ | ||
{ | ||
units: "ms", | ||
divisor: 1 | ||
}, { | ||
units: "s", | ||
divisor: 1000 | ||
}, { | ||
units: "m", | ||
divisor: 60 | ||
}, { | ||
units: "h", | ||
divisor: 60 | ||
}, { | ||
units: "d", | ||
divisor: 24 | ||
}, { | ||
units: "y", | ||
divisor: 365.24 | ||
} | ||
]; | ||
|
||
module.exports = { | ||
AGGREGATE_TIME_LEVELS: AGGREGATE_TIME_LEVELS, | ||
TIME_SCALES: TIME_SCALES | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to include the PR reference at the bottom of the file.