uniform versioning with/without release assets #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of buildpacks that use freezer are versioned x.y.z (x,y,z being whole numbers) but their releases are tagged vX.Y.Z This means that for buildpack releases that have attached assets, freezer packages them with version X.Y.Z and for those without assets, it packages them as vX.Y.Z. This commit trims the v prefix to bring uniformity
|
Would you be willing update the tests to see that this functionality is working? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of buildpacks that use freezer are versioned X.Y.Z (X,Y,Z being
whole numbers) but their releases are tagged vX.Y.Z
This means that for buildpack releases that have attached assets,
freezer packages them with version X.Y.Z and for those without assets,
it packages them as vX.Y.Z.
This commit trims the v prefix to bring uniformity