Updated for Torch v1.10.2, and NNlib >= v0.8#64
Merged
stemann merged 4 commits intoFluxML:masterfrom Nov 16, 2024
Merged
Conversation
Closed
3db9d60 to
5d1cfc1
Compare
b8c7c7b to
4afecd8
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
4afecd8 to
78fcb8f
Compare
78fcb8f to
f547c13
Compare
Collaborator
Author
|
Will merge this tomorrow if there are no objections. |
Collaborator
Author
|
Will to some extent also remedy #20 - a re-build of Torch_jll using lazy artifacts is required before CUDA can be optional on Linux x86_64: JuliaPackaging/Yggdrasil#9785 |
f547c13 to
b3eb223
Compare
Replaced Torch_jll v1.4 with TorchCAPI_jll v0.2; TorchCAPI_jll v0.2 is supported by Torch_jll v1.10.2. Torch_jll uses extended platform selection (platform augmentation) which requires Julia 1.7+. Updated Julia wrapper using Julia wrapper generator (using Julia 1.11). Updated usages of functions changed in FluxML#61 (Updated C wrapper): at_grad_set_enabled.
Testing on Julia 1.6 with CUDA is no longer possible, as the extended platform selection (platform augmentation) requires Julia 1.7+.
b3eb223 to
77ecce7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced Torch_jll v1.4 with TorchCAPI_jll v0.2; TorchCAPI_jll v0.2 is supported by Torch_jll v1.10.2.
Torch_jll uses extended platform selection (platform augmentation) which requires Julia 1.7+.
Updated Julia wrapper using Julia wrapper generator (using Julia 1.11).
Updated usages of functions changed in #61 (Updated C wrapper): E.g.,
at_grad_set_enabled.Also:
Resolves #17
Resolves #42
Resolves #50
Resolves #54
Also,