Updated Julia wrapper generator#59
Merged
ToucheSir merged 1 commit intoFluxML:masterfrom Nov 11, 2023
Merged
Conversation
stemann
force-pushed
the
feature/update_julia_wrapper_generator
branch
from
444892b to
83d9a44
Compare
Member
|
Really excited to see this come through! |
Collaborator
Author
|
Yes - me too ... finally! :-) If you have time, please take a look at the changes between src/wrap/libdoeye_caml_generated.jl and src/wrapper.jl - it's not exactly a zero diff yet :-) |
Collaborator
Author
|
Would like to get Buildkite CI running (e.g. #60) before merging this (if it comes with a lot of auto-generated changes). |
stemann
force-pushed
the
feature/update_julia_wrapper_generator
branch
from
83d9a44 to
c6b4011
Compare
3 tasks
stemann
force-pushed
the
feature/update_julia_wrapper_generator
branch
from
c6b4011 to
c1c021e
Compare
stemann
force-pushed
the
feature/update_julia_wrapper_generator
branch
4 times, most recently
from
f54008a to
da80a90
Compare
stemann
changed the title
Collaborator
Author
|
The diff from src/wrap/libdoeye_caml_generated.jl to src/wrapper.jl is now reasonably close to a zero-diff - ignoring the change from |
stemann
commented
Nov 11, 2023
stemann
commented
Nov 11, 2023
ToucheSir
approved these changes
Nov 11, 2023
Member
ToucheSir
left a comment
ToucheSir
left a comment
There was a problem hiding this comment.
Anything left to get in before I merge?
stemann
force-pushed
the
feature/update_julia_wrapper_generator
branch
from
da80a90 to
cae459f
Compare
Also: * Re-organized Julia wrapper - and Julia wrapper generator. * Replaced Torch.at_dim with Base.ndims(::Tensor) - avoids method ambiguity among Torch.Wrapper.at_dim and Torch.at_dim.
stemann
force-pushed
the
feature/update_julia_wrapper_generator
branch
from
cae459f to
c87bd0d
Compare
Collaborator
Author
|
Nothing further from here. LGTM :-) |
Closed
DhairyaLGandhi
approved these changes
Nov 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP reason: Quite a lot changes between src/wrap/libdoeye_caml_generated.jl and src/wrapper.jl. Fixed.Also, re-organized Julia wrapper - and Julia wrapper generator.