Support typed parameters inside unions #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is my first time working with the internals of MacroTools. I may have done something wrong. I'd appreciate as much review attention as you can spare.
This supports typed parameters inside unions for the
@match
macro (fixes #36 ) by cleaning up some of the quoting procedures insidetypes.jl
. The one sketchy part is that I calleval()
intypes.jl
to convert:Symbol
into the typeSymbol
. That feels wrong to me, and it may be possible to avoid it.The
ensurequoted
method inmacro.jl
exists so thatsubtb
can return aTypeBind
directly instead of an expression that somehow interpolates to aTypeBind
, while still working with plain Expr and Symbol inputs.