Fix readstring undefined error on 0.4 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah cool, I didn't even realise that MacroTools had any dependents. Thanks! |
aviatesk
added a commit
to aviatesk/MacroTools.jl
that referenced
this pull request
Apr 16, 2021
I ran [JET analysis](https://github.com/aviatesk/JET.jl) on this package, and fixed some true positive errors. > run JET on `MacroTools` ```julia julia> using JET julia> report_file("src/MacroTools.jl"; analyze_from_definitions = true, annotate_types = true) ``` > Before this PR ```julia ═════ 11 possible errors found ═════ ┌ @ src/match/match.jl:27 Base.getproperty(Base.getproperty(MacroTools.Base, :match::Symbol)::typeof(match)(r"^@?(.*?)_+(_str)?$", MacroTools.string(s::Symbol)::String)::Union{Nothing, RegexMatch}, :captures::Symbol) │┌ @ Base.jl:33 Base.getfield(x::Nothing, f::Symbol) ││ type Nothing has no field captures │└────────────── ┌ @ src/match/types.jl:20 MacroTools.map(MacroTools.totype, ts::Vector{Symbol}) │┌ @ abstractarray.jl:2301 Base.collect_similar(A::Vector{Symbol}, Base.Generator(f::typeof(MacroTools.totype), A::Vector{Symbol})::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)}) ││┌ @ array.jl:620 Base._collect(cont::Vector{Symbol}, itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)}, Base.IteratorEltype(itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)})::Base.EltypeUnknown, Base.IteratorSize(itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)})::Base.HasShape{1}) │││┌ @ array.jl:710 Base.collect_to_with_first!(Base._similar_for(c::Vector{Symbol}, Base.typeof(v1::Union{Expr, Symbol})::Union{Type{Expr}, Type{Symbol}}, itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)}, isz::Base.HasShape{1})::Union{Vector{Expr}, Vector{Symbol}}, v1::Union{Expr, Symbol}, itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)}, st::Int64) ││││┌ @ array.jl:715 Base.setindex!(dest::Vector{Symbol}, v1::Expr, i1::Int64) │││││┌ @ array.jl:853 Base.convert(_::Type{Symbol}, x::Expr) ││││││ no matching method found for call signature: Base.convert(_::Type{Symbol}, x::Expr) │││││└──────────────── ││││┌ @ array.jl:715 Base.setindex!(dest::Vector{Expr}, v1::Symbol, i1::Int64) │││││┌ @ array.jl:853 Base.convert(_::Type{Expr}, x::Symbol) ││││││ no matching method found for call signature: Base.convert(_::Type{Expr}, x::Symbol) │││││└──────────────── ┌ @ src/utils.jl:21 Base.collect(Base.Generator(FluxML#11::MacroTools.var"FluxML#11#12", MacroTools.map(MacroTools.esc, xs::Tuple)::Any)::Base.Generator{_A, MacroTools.var"FluxML#11#12"} where _A) │┌ @ array.jl:697 Base.collect_to_with_first!(Base._array_for(Base.typeof(v1::Expr)::Type{Expr}, Base.getproperty(itr::Base.Generator{_A, MacroTools.var"FluxML#11#12"} where _A, :iter::Symbol)::Any, isz::Any)::Any, v1::Expr, itr::Base.Generator{_A, MacroTools.var"FluxML#11#12"} where _A, st::Any) ││┌ @ array.jl:721 Base.grow_to!(dest::Any, itr::Base.Generator{_A, MacroTools.var"FluxML#11#12"} where _A, st::Any) │││┌ @ dict.jl:153 Base.indexed_iterate(Core.getfield(Base.indexed_iterate(y::Tuple{Expr, Any}, 1)::Tuple{Expr, Int64}, 1)::Expr, 1) ││││┌ @ tuple.jl:89 Base.iterate(I::Expr) │││││ no matching method found for call signature: Base.iterate(I::Expr) ││││└─────────────── ┌ @ src/utils.jl:423 MacroTools.rebuilddef(MacroTools.striplines(dict::Dict)::Dict) │ variable MacroTools.rebuilddef is not defined: MacroTools.rebuilddef(MacroTools.striplines(dict::Dict)::Dict) └──────────────────── ┌ @ src/utils.jl:455 Core.tuple(splitvar::MacroTools.var"#splitvar#35"(arg::Any)::Union{Nothing, Tuple{Any, Any}}, Core.tuple(is_splat::Bool, default::Any)::Tuple{Bool, Any}...) │ no matching method found for call signature: Core.tuple(splitvar::MacroTools.var"#splitvar#35"(arg::Any)::Union{Nothing, Tuple{Any, Any}}, Core.tuple(is_splat::Bool, default::Any)::Tuple{Bool, Any}...) └──────────────────── ┌ @ src/utils.jl:457 Core.tuple(splitvar::MacroTools.var"#splitvar#35"(arg_expr2::Any)::Union{Nothing, Tuple{Any, Any}}, Core.tuple(is_splat::Bool, MacroTools.nothing)::Tuple{Bool, Nothing}...) │ no matching method found for call signature: Core.tuple(splitvar::MacroTools.var"#splitvar#35"(arg_expr2::Any)::Union{Nothing, Tuple{Any, Any}}, Core.tuple(is_splat::Bool, MacroTools.nothing)::Tuple{Bool, Nothing}...) └──────────────────── ┌ @ src/structdef.jl:13 MacroTools.parse_error(ex::Any) │ variable MacroTools.parse_error is not defined: MacroTools.parse_error(ex::Any) └─────────────────────── ┌ @ src/structdef.jl:21 MacroTools.parse_error(ex::Any) │ variable MacroTools.parse_error is not defined: MacroTools.parse_error(ex::Any) └─────────────────────── ┌ @ src/structdef.jl:29 MacroTools.parse_error(ex::Any) │ variable MacroTools.parse_error is not defined: MacroTools.parse_error(ex::Any) └─────────────────────── ┌ @ src/examples/destruct.jl:24 MacroTools.error("Can't destructure fields with default values") │┌ @ error.jl:33 error(::String) ││ may throw: Base.throw($(Expr(:invoke, MethodInstance for ErrorException(::String), :(Base.ErrorException), Core.Argument(2)))::ErrorException) │└─────────────── ``` > After this PR: only the false positives ramain (Julia's inference or JET itself should be improved) ```julia ═════ 4 possible errors found ═════ ┌ @ src/match/types.jl:20 MacroTools.map(MacroTools.totype, ts::Vector{Symbol}) │┌ @ abstractarray.jl:2301 Base.collect_similar(A::Vector{Symbol}, Base.Generator(f::typeof(MacroTools.totype), A::Vector{Symbol})::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)}) ││┌ @ array.jl:620 Base._collect(cont::Vector{Symbol}, itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)}, Base.IteratorEltype(itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)})::Base.EltypeUnknown, Base.IteratorSize(itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)})::Base.HasShape{1}) │││┌ @ array.jl:710 Base.collect_to_with_first!(Base._similar_for(c::Vector{Symbol}, Base.typeof(v1::Union{Expr, Symbol})::Union{Type{Expr}, Type{Symbol}}, itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)}, isz::Base.HasShape{1})::Union{Vector{Expr}, Vector{Symbol}}, v1::Union{Expr, Symbol}, itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)}, st::Int64) ││││┌ @ array.jl:715 Base.setindex!(dest::Vector{Symbol}, v1::Expr, i1::Int64) │││││┌ @ array.jl:853 Base.convert(_::Type{Symbol}, x::Expr) ││││││ no matching method found for call signature: Base.convert(_::Type{Symbol}, x::Expr) │││││└──────────────── ││││┌ @ array.jl:715 Base.setindex!(dest::Vector{Expr}, v1::Symbol, i1::Int64) │││││┌ @ array.jl:853 Base.convert(_::Type{Expr}, x::Symbol) ││││││ no matching method found for call signature: Base.convert(_::Type{Expr}, x::Symbol) │││││└──────────────── ┌ @ src/utils.jl:21 Base.collect(Base.Generator(FluxML#11::MacroTools.var"FluxML#11#12", MacroTools.map(MacroTools.esc, xs::Tuple)::Any)::Base.Generator{_A, MacroTools.var"FluxML#11#12"} where _A) │┌ @ array.jl:697 Base.collect_to_with_first!(Base._array_for(Base.typeof(v1::Expr)::Type{Expr}, Base.getproperty(itr::Base.Generator{_A, MacroTools.var"FluxML#11#12"} where _A, :iter::Symbol)::Any, isz::Any)::Any, v1::Expr, itr::Base.Generator{_A, MacroTools.var"FluxML#11#12"} where _A, st::Any) ││┌ @ array.jl:721 Base.grow_to!(dest::Any, itr::Base.Generator{_A, MacroTools.var"FluxML#11#12"} where _A, st::Any) │││┌ @ dict.jl:153 Base.indexed_iterate(Core.getfield(Base.indexed_iterate(y::Tuple{Expr, Any}, 1)::Tuple{Expr, Int64}, 1)::Expr, 1) ││││┌ @ tuple.jl:89 Base.iterate(I::Expr) │││││ no matching method found for call signature: Base.iterate(I::Expr) ││││└─────────────── ┌ @ src/examples/destruct.jl:24 MacroTools.error("Can't destructure fields with default values") │┌ @ error.jl:33 error(::String) ││ may throw: Base.throw($(Expr(:invoke, MethodInstance for ErrorException(::String), :(Base.ErrorException), Core.Argument(2)))::ErrorException) │└─────────────── ```
aviatesk
added a commit
to aviatesk/MacroTools.jl
that referenced
this pull request
Apr 16, 2021
I ran [JET analysis](https://github.com/aviatesk/JET.jl) on this package, and fixed some true positive errors. > run JET on `MacroTools` ```julia julia> using JET julia> report_file("src/MacroTools.jl"; analyze_from_definitions = true, annotate_types = true) ``` > Before this PR ```julia ═════ 11 possible errors found ═════ ┌ @ src/match/match.jl:27 Base.getproperty(Base.getproperty(MacroTools.Base, :match::Symbol)::typeof(match)(r"^@?(.*?)_+(_str)?$", MacroTools.string(s::Symbol)::String)::Union{Nothing, RegexMatch}, :captures::Symbol) │┌ @ Base.jl:33 Base.getfield(x::Nothing, f::Symbol) ││ type Nothing has no field captures │└────────────── ┌ @ src/match/types.jl:20 MacroTools.map(MacroTools.totype, ts::Vector{Symbol}) │┌ @ abstractarray.jl:2301 Base.collect_similar(A::Vector{Symbol}, Base.Generator(f::typeof(MacroTools.totype), A::Vector{Symbol})::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)}) ││┌ @ array.jl:620 Base._collect(cont::Vector{Symbol}, itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)}, Base.IteratorEltype(itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)})::Base.EltypeUnknown, Base.IteratorSize(itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)})::Base.HasShape{1}) │││┌ @ array.jl:710 Base.collect_to_with_first!(Base._similar_for(c::Vector{Symbol}, Base.typeof(v1::Union{Expr, Symbol})::Union{Type{Expr}, Type{Symbol}}, itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)}, isz::Base.HasShape{1})::Union{Vector{Expr}, Vector{Symbol}}, v1::Union{Expr, Symbol}, itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)}, st::Int64) ││││┌ @ array.jl:715 Base.setindex!(dest::Vector{Symbol}, v1::Expr, i1::Int64) │││││┌ @ array.jl:853 Base.convert(_::Type{Symbol}, x::Expr) ││││││ no matching method found for call signature: Base.convert(_::Type{Symbol}, x::Expr) │││││└──────────────── ││││┌ @ array.jl:715 Base.setindex!(dest::Vector{Expr}, v1::Symbol, i1::Int64) │││││┌ @ array.jl:853 Base.convert(_::Type{Expr}, x::Symbol) ││││││ no matching method found for call signature: Base.convert(_::Type{Expr}, x::Symbol) │││││└──────────────── ┌ @ src/utils.jl:21 Base.collect(Base.Generator(FluxML#11::MacroTools.var"FluxML#11#12", MacroTools.map(MacroTools.esc, xs::Tuple)::Any)::Base.Generator{_A, MacroTools.var"FluxML#11#12"} where _A) │┌ @ array.jl:697 Base.collect_to_with_first!(Base._array_for(Base.typeof(v1::Expr)::Type{Expr}, Base.getproperty(itr::Base.Generator{_A, MacroTools.var"FluxML#11#12"} where _A, :iter::Symbol)::Any, isz::Any)::Any, v1::Expr, itr::Base.Generator{_A, MacroTools.var"FluxML#11#12"} where _A, st::Any) ││┌ @ array.jl:721 Base.grow_to!(dest::Any, itr::Base.Generator{_A, MacroTools.var"FluxML#11#12"} where _A, st::Any) │││┌ @ dict.jl:153 Base.indexed_iterate(Core.getfield(Base.indexed_iterate(y::Tuple{Expr, Any}, 1)::Tuple{Expr, Int64}, 1)::Expr, 1) ││││┌ @ tuple.jl:89 Base.iterate(I::Expr) │││││ no matching method found for call signature: Base.iterate(I::Expr) ││││└─────────────── ┌ @ src/utils.jl:423 MacroTools.rebuilddef(MacroTools.striplines(dict::Dict)::Dict) │ variable MacroTools.rebuilddef is not defined: MacroTools.rebuilddef(MacroTools.striplines(dict::Dict)::Dict) └──────────────────── ┌ @ src/utils.jl:455 Core.tuple(splitvar::MacroTools.var"#splitvar#35"(arg::Any)::Union{Nothing, Tuple{Any, Any}}, Core.tuple(is_splat::Bool, default::Any)::Tuple{Bool, Any}...) │ no matching method found for call signature: Core.tuple(splitvar::MacroTools.var"#splitvar#35"(arg::Any)::Union{Nothing, Tuple{Any, Any}}, Core.tuple(is_splat::Bool, default::Any)::Tuple{Bool, Any}...) └──────────────────── ┌ @ src/utils.jl:457 Core.tuple(splitvar::MacroTools.var"#splitvar#35"(arg_expr2::Any)::Union{Nothing, Tuple{Any, Any}}, Core.tuple(is_splat::Bool, MacroTools.nothing)::Tuple{Bool, Nothing}...) │ no matching method found for call signature: Core.tuple(splitvar::MacroTools.var"#splitvar#35"(arg_expr2::Any)::Union{Nothing, Tuple{Any, Any}}, Core.tuple(is_splat::Bool, MacroTools.nothing)::Tuple{Bool, Nothing}...) └──────────────────── ┌ @ src/structdef.jl:13 MacroTools.parse_error(ex::Any) │ variable MacroTools.parse_error is not defined: MacroTools.parse_error(ex::Any) └─────────────────────── ┌ @ src/structdef.jl:21 MacroTools.parse_error(ex::Any) │ variable MacroTools.parse_error is not defined: MacroTools.parse_error(ex::Any) └─────────────────────── ┌ @ src/structdef.jl:29 MacroTools.parse_error(ex::Any) │ variable MacroTools.parse_error is not defined: MacroTools.parse_error(ex::Any) └─────────────────────── ┌ @ src/examples/destruct.jl:24 MacroTools.error("Can't destructure fields with default values") │┌ @ error.jl:33 error(::String) ││ may throw: Base.throw($(Expr(:invoke, MethodInstance for ErrorException(::String), :(Base.ErrorException), Core.Argument(2)))::ErrorException) │└─────────────── ``` > After this PR: only the false positives ramain (Julia's inference or JET itself should be improved) ```julia ═════ 4 possible errors found ═════ ┌ @ src/match/types.jl:20 MacroTools.map(MacroTools.totype, ts::Vector{Symbol}) │┌ @ abstractarray.jl:2301 Base.collect_similar(A::Vector{Symbol}, Base.Generator(f::typeof(MacroTools.totype), A::Vector{Symbol})::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)}) ││┌ @ array.jl:620 Base._collect(cont::Vector{Symbol}, itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)}, Base.IteratorEltype(itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)})::Base.EltypeUnknown, Base.IteratorSize(itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)})::Base.HasShape{1}) │││┌ @ array.jl:710 Base.collect_to_with_first!(Base._similar_for(c::Vector{Symbol}, Base.typeof(v1::Union{Expr, Symbol})::Union{Type{Expr}, Type{Symbol}}, itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)}, isz::Base.HasShape{1})::Union{Vector{Expr}, Vector{Symbol}}, v1::Union{Expr, Symbol}, itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)}, st::Int64) ││││┌ @ array.jl:715 Base.setindex!(dest::Vector{Symbol}, v1::Expr, i1::Int64) │││││┌ @ array.jl:853 Base.convert(_::Type{Symbol}, x::Expr) ││││││ no matching method found for call signature: Base.convert(_::Type{Symbol}, x::Expr) │││││└──────────────── ││││┌ @ array.jl:715 Base.setindex!(dest::Vector{Expr}, v1::Symbol, i1::Int64) │││││┌ @ array.jl:853 Base.convert(_::Type{Expr}, x::Symbol) ││││││ no matching method found for call signature: Base.convert(_::Type{Expr}, x::Symbol) │││││└──────────────── ┌ @ src/utils.jl:21 Base.collect(Base.Generator(FluxML#11::MacroTools.var"FluxML#11#12", MacroTools.map(MacroTools.esc, xs::Tuple)::Any)::Base.Generator{_A, MacroTools.var"FluxML#11#12"} where _A) │┌ @ array.jl:697 Base.collect_to_with_first!(Base._array_for(Base.typeof(v1::Expr)::Type{Expr}, Base.getproperty(itr::Base.Generator{_A, MacroTools.var"FluxML#11#12"} where _A, :iter::Symbol)::Any, isz::Any)::Any, v1::Expr, itr::Base.Generator{_A, MacroTools.var"FluxML#11#12"} where _A, st::Any) ││┌ @ array.jl:721 Base.grow_to!(dest::Any, itr::Base.Generator{_A, MacroTools.var"FluxML#11#12"} where _A, st::Any) │││┌ @ dict.jl:153 Base.indexed_iterate(Core.getfield(Base.indexed_iterate(y::Tuple{Expr, Any}, 1)::Tuple{Expr, Int64}, 1)::Expr, 1) ││││┌ @ tuple.jl:89 Base.iterate(I::Expr) │││││ no matching method found for call signature: Base.iterate(I::Expr) ││││└─────────────── ┌ @ src/examples/destruct.jl:24 MacroTools.error("Can't destructure fields with default values") │┌ @ error.jl:33 error(::String) ││ may throw: Base.throw($(Expr(:invoke, MethodInstance for ErrorException(::String), :(Base.ErrorException), Core.Argument(2)))::ErrorException) │└─────────────── ```
aviatesk
added a commit
to aviatesk/MacroTools.jl
that referenced
this pull request
May 4, 2021
I ran [JET analysis](https://github.com/aviatesk/JET.jl) on this package, and fixed some true positive errors. > run JET on `MacroTools` ```julia julia> using JET julia> report_file("src/MacroTools.jl"; analyze_from_definitions = true, annotate_types = true) ``` > Before this PR ```julia ═════ 11 possible errors found ═════ ┌ @ src/match/match.jl:27 Base.getproperty(Base.getproperty(MacroTools.Base, :match::Symbol)::typeof(match)(r"^@?(.*?)_+(_str)?$", MacroTools.string(s::Symbol)::String)::Union{Nothing, RegexMatch}, :captures::Symbol) │┌ @ Base.jl:33 Base.getfield(x::Nothing, f::Symbol) ││ type Nothing has no field captures │└────────────── ┌ @ src/match/types.jl:20 MacroTools.map(MacroTools.totype, ts::Vector{Symbol}) │┌ @ abstractarray.jl:2301 Base.collect_similar(A::Vector{Symbol}, Base.Generator(f::typeof(MacroTools.totype), A::Vector{Symbol})::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)}) ││┌ @ array.jl:620 Base._collect(cont::Vector{Symbol}, itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)}, Base.IteratorEltype(itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)})::Base.EltypeUnknown, Base.IteratorSize(itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)})::Base.HasShape{1}) │││┌ @ array.jl:710 Base.collect_to_with_first!(Base._similar_for(c::Vector{Symbol}, Base.typeof(v1::Union{Expr, Symbol})::Union{Type{Expr}, Type{Symbol}}, itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)}, isz::Base.HasShape{1})::Union{Vector{Expr}, Vector{Symbol}}, v1::Union{Expr, Symbol}, itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)}, st::Int64) ││││┌ @ array.jl:715 Base.setindex!(dest::Vector{Symbol}, v1::Expr, i1::Int64) │││││┌ @ array.jl:853 Base.convert(_::Type{Symbol}, x::Expr) ││││││ no matching method found for call signature: Base.convert(_::Type{Symbol}, x::Expr) │││││└──────────────── ││││┌ @ array.jl:715 Base.setindex!(dest::Vector{Expr}, v1::Symbol, i1::Int64) │││││┌ @ array.jl:853 Base.convert(_::Type{Expr}, x::Symbol) ││││││ no matching method found for call signature: Base.convert(_::Type{Expr}, x::Symbol) │││││└──────────────── ┌ @ src/utils.jl:21 Base.collect(Base.Generator(FluxML#11::MacroTools.var"FluxML#11#12", MacroTools.map(MacroTools.esc, xs::Tuple)::Any)::Base.Generator{_A, MacroTools.var"FluxML#11#12"} where _A) │┌ @ array.jl:697 Base.collect_to_with_first!(Base._array_for(Base.typeof(v1::Expr)::Type{Expr}, Base.getproperty(itr::Base.Generator{_A, MacroTools.var"FluxML#11#12"} where _A, :iter::Symbol)::Any, isz::Any)::Any, v1::Expr, itr::Base.Generator{_A, MacroTools.var"FluxML#11#12"} where _A, st::Any) ││┌ @ array.jl:721 Base.grow_to!(dest::Any, itr::Base.Generator{_A, MacroTools.var"FluxML#11#12"} where _A, st::Any) │││┌ @ dict.jl:153 Base.indexed_iterate(Core.getfield(Base.indexed_iterate(y::Tuple{Expr, Any}, 1)::Tuple{Expr, Int64}, 1)::Expr, 1) ││││┌ @ tuple.jl:89 Base.iterate(I::Expr) │││││ no matching method found for call signature: Base.iterate(I::Expr) ││││└─────────────── ┌ @ src/utils.jl:423 MacroTools.rebuilddef(MacroTools.striplines(dict::Dict)::Dict) │ variable MacroTools.rebuilddef is not defined: MacroTools.rebuilddef(MacroTools.striplines(dict::Dict)::Dict) └──────────────────── ┌ @ src/utils.jl:455 Core.tuple(splitvar::MacroTools.var"#splitvar#35"(arg::Any)::Union{Nothing, Tuple{Any, Any}}, Core.tuple(is_splat::Bool, default::Any)::Tuple{Bool, Any}...) │ no matching method found for call signature: Core.tuple(splitvar::MacroTools.var"#splitvar#35"(arg::Any)::Union{Nothing, Tuple{Any, Any}}, Core.tuple(is_splat::Bool, default::Any)::Tuple{Bool, Any}...) └──────────────────── ┌ @ src/utils.jl:457 Core.tuple(splitvar::MacroTools.var"#splitvar#35"(arg_expr2::Any)::Union{Nothing, Tuple{Any, Any}}, Core.tuple(is_splat::Bool, MacroTools.nothing)::Tuple{Bool, Nothing}...) │ no matching method found for call signature: Core.tuple(splitvar::MacroTools.var"#splitvar#35"(arg_expr2::Any)::Union{Nothing, Tuple{Any, Any}}, Core.tuple(is_splat::Bool, MacroTools.nothing)::Tuple{Bool, Nothing}...) └──────────────────── ┌ @ src/structdef.jl:13 MacroTools.parse_error(ex::Any) │ variable MacroTools.parse_error is not defined: MacroTools.parse_error(ex::Any) └─────────────────────── ┌ @ src/structdef.jl:21 MacroTools.parse_error(ex::Any) │ variable MacroTools.parse_error is not defined: MacroTools.parse_error(ex::Any) └─────────────────────── ┌ @ src/structdef.jl:29 MacroTools.parse_error(ex::Any) │ variable MacroTools.parse_error is not defined: MacroTools.parse_error(ex::Any) └─────────────────────── ┌ @ src/examples/destruct.jl:24 MacroTools.error("Can't destructure fields with default values") │┌ @ error.jl:33 error(::String) ││ may throw: Base.throw($(Expr(:invoke, MethodInstance for ErrorException(::String), :(Base.ErrorException), Core.Argument(2)))::ErrorException) │└─────────────── ``` > After this PR: only the false positives ramain (Julia's inference or JET itself should be improved) ```julia ═════ 4 possible errors found ═════ ┌ @ src/match/types.jl:20 MacroTools.map(MacroTools.totype, ts::Vector{Symbol}) │┌ @ abstractarray.jl:2301 Base.collect_similar(A::Vector{Symbol}, Base.Generator(f::typeof(MacroTools.totype), A::Vector{Symbol})::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)}) ││┌ @ array.jl:620 Base._collect(cont::Vector{Symbol}, itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)}, Base.IteratorEltype(itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)})::Base.EltypeUnknown, Base.IteratorSize(itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)})::Base.HasShape{1}) │││┌ @ array.jl:710 Base.collect_to_with_first!(Base._similar_for(c::Vector{Symbol}, Base.typeof(v1::Union{Expr, Symbol})::Union{Type{Expr}, Type{Symbol}}, itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)}, isz::Base.HasShape{1})::Union{Vector{Expr}, Vector{Symbol}}, v1::Union{Expr, Symbol}, itr::Base.Generator{Vector{Symbol}, typeof(MacroTools.totype)}, st::Int64) ││││┌ @ array.jl:715 Base.setindex!(dest::Vector{Symbol}, v1::Expr, i1::Int64) │││││┌ @ array.jl:853 Base.convert(_::Type{Symbol}, x::Expr) ││││││ no matching method found for call signature: Base.convert(_::Type{Symbol}, x::Expr) │││││└──────────────── ││││┌ @ array.jl:715 Base.setindex!(dest::Vector{Expr}, v1::Symbol, i1::Int64) │││││┌ @ array.jl:853 Base.convert(_::Type{Expr}, x::Symbol) ││││││ no matching method found for call signature: Base.convert(_::Type{Expr}, x::Symbol) │││││└──────────────── ┌ @ src/utils.jl:21 Base.collect(Base.Generator(FluxML#11::MacroTools.var"FluxML#11#12", MacroTools.map(MacroTools.esc, xs::Tuple)::Any)::Base.Generator{_A, MacroTools.var"FluxML#11#12"} where _A) │┌ @ array.jl:697 Base.collect_to_with_first!(Base._array_for(Base.typeof(v1::Expr)::Type{Expr}, Base.getproperty(itr::Base.Generator{_A, MacroTools.var"FluxML#11#12"} where _A, :iter::Symbol)::Any, isz::Any)::Any, v1::Expr, itr::Base.Generator{_A, MacroTools.var"FluxML#11#12"} where _A, st::Any) ││┌ @ array.jl:721 Base.grow_to!(dest::Any, itr::Base.Generator{_A, MacroTools.var"FluxML#11#12"} where _A, st::Any) │││┌ @ dict.jl:153 Base.indexed_iterate(Core.getfield(Base.indexed_iterate(y::Tuple{Expr, Any}, 1)::Tuple{Expr, Int64}, 1)::Expr, 1) ││││┌ @ tuple.jl:89 Base.iterate(I::Expr) │││││ no matching method found for call signature: Base.iterate(I::Expr) ││││└─────────────── ┌ @ src/examples/destruct.jl:24 MacroTools.error("Can't destructure fields with default values") │┌ @ error.jl:33 error(::String) ││ may throw: Base.throw($(Expr(:invoke, MethodInstance for ErrorException(::String), :(Base.ErrorException), Core.Argument(2)))::ErrorException) │└─────────────── ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks PyPlot on 0.4.