Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove flutter_svg clipBehavoir daprecation close #378 #379

Closed
wants to merge 2 commits into from
Closed

remove flutter_svg clipBehavoir daprecation close #378 #379

wants to merge 2 commits into from

Conversation

hasanmhallak
Copy link

@hasanmhallak hasanmhallak commented Apr 3, 2023

What does this change?

flutter_svg publish a new version that Reintroduce clipBehavior see this this well make a conflict in each time you run the generator because clipBeavior argument cannot accept null. this pull request fix this issue.

Fixes #378 #368 🎯

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
    • Ensure the tests (melos run unit:test)
    • Ensure the analyzer and formatter pass (melos run format to automatically apply formatting)
  • Appropriate docs were updated (if necessary)

@hasanmhallak hasanmhallak requested a review from wasabeef as a code owner April 3, 2023 23:49
@chyiiiiiiiiiiii
Copy link

Need to be fixed. Thanks~

@wasabeef
Copy link
Member

@hasanmhallak
I merged the one that came first. And I appreciate everyone's contributions.

@wasabeef wasabeef closed this Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Generated svg function should be generated with a default value of [clipBehavior].
3 participants