Build spring clean #198
Merged
Build spring clean #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephankramer
previously approved these changes
May 13, 2018
|
I've got no idea whether MPI still misbehaves enough anywhere to need to cd back to the working directory on any system we still support. If not, then I'd be very happy to remove it all. @tmbgreaves Any chance of a xenial buildbot queue for this, since it does have a non-zero chance of breaking something, and it would be nice to keep that green at least. |
Closed
stephankramer
approved these changes
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset attempts to silence some of the superfluous warnings that fluidity currently spits out during building. The biggest things it doesn't deal with are an upstream warning from spud, and an issue caused by two different files in population_balance both producing a module with the same name. It also implements jrmaddison's suggestion in #119 to stop spatialindex from making temporary files.