Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to IPv4 when creating socket if IPv6 is not available (#1208) #1265

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Fallback to IPv4 when creating socket if IPv6 is not available (#1208) #1265

merged 1 commit into from
Aug 5, 2023

Conversation

ivan-zaera
Copy link
Contributor

@ivan-zaera ivan-zaera commented Aug 4, 2023 •
edited
Loading

Fixes #1208

@ivan-zaera
Copy link
Contributor Author

I can only compile the project in Linux, so I'm going to need some guidance on how to make failing platforms compile...

@sonarcloud
Copy link

sonarcloud bot commented Aug 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

derselbst
derselbst approved these changes Aug 5, 2023
View reviewed changes
Copy link
Member

@derselbst derselbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks!

The failing builds were already failing before. I'll try to find some time looking into that.

@derselbst derselbst merged commit ca65e6f into FluidSynth:master Aug 5, 2023
39 of 55 checks passed
DominusExult added a commit to DominusExult/fluidsynth-sans-glib that referenced this pull request Mar 6, 2024
@DominusExult
Merge commit '683270db64302e59d26b9610514af1cfe0a80493' into sans_glib
2c7e16d 
* commit '683270db64302e59d26b9610514af1cfe0a80493':
  Bump to 2.3.5
  Fix libinstpatch and sndfile not being discovered on Windows (FluidSynth#1299)
  Update FreeBSD CI: Drop 12.4 and add 14.0
  Fix some rounding issues due to double promotion (FluidSynth#1286)
  Bump to 2.3.4
  Fix player termination after stopping and restarting (FluidSynth#1273)
  fix for issue FluidSynth#1268: Pipewire's Jack implementation not found (FluidSynth#1269)
  Fix issue with CMake Xcode generator (FluidSynth#1266)
  Refurbish CI (FluidSynth#1267)
  Fallback to IPv4 when creating socket if IPv6 is not available (FluidSynth#1208) (FluidSynth#1265)
  Turn off pending notes and issue a warning (FluidSynth#1264)
  Fix incorrect way of turning CMAKE_INSTALL_LIBDIR absolute (FluidSynth#1261)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derselbst derselbst derselbst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement IPv6 to IPv4 fallback
2 participants
@ivan-zaera @derselbst