Modify select drivers to pass system realtime messages #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
re-creating this PR with 2.2.x as the base per comments in #1113 |
|
Kudos, SonarCloud Quality Gate passed! |
derselbst
approved these changes
Jun 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FluidSynth's various MIDI drivers don't appear to pass along system realtime messages (i.e. MIDI clock, start, stop, etc.) to the driver's handler/callback. These messages could be useful if, for example, the user writes a custom callback that can use these messages to synchronize a fluid_sequencer to an external clock.
This pull modifies the alsa_seq and winmidi drivers, as well as any that use
fluid_midi_parser_parse, to pass along system realtime messages (status byte F8-FF) to the callback. I don't think it will cause problems further down the chain, sincefluid_midi_router_handle_midi_eventwill just return them as NULL. This behavior could be added to other drivers in future if desired.