Added support for iPhone X Safe Area. #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cheesebaron
approved these changes
Aug 7, 2018
gshackles
requested changes
Aug 9, 2018
Member
gshackles
left a comment
gshackles
left a comment
There was a problem hiding this comment.
Looks great! Could you add in a quick page into the sample app that demonstrates this in use?
Edited info.plist: upgraded MinimumOSVersion from 7.0 to 8.0 Added LaunchScreen storyboard to allow app run full screen on iPhone X.
Contributor
Author
|
@gshackles I've added ViewWithSafeArea sample to quick page, also update QuickLayout MinimumOSVersion from 7.0 to 8.0 and added LaunchScreen storyboard to avoid iPhone X not using entire screen issue. |
jzeferino
approved these changes
Sep 12, 2018
fedemkr
reviewed
Oct 29, 2018
Contributor
fedemkr
left a comment
fedemkr
left a comment
There was a problem hiding this comment.
Change to use Minus for the margin in AtRightOfWithSafeArea and AtBottomOfWithSafeArea
Co-Authored-By: FabriBertani <[email protected]>
Co-Authored-By: FabriBertani <[email protected]>
gshackles
approved these changes
Oct 30, 2018
Member
|
Sorry for the delay, and thanks for contributing this! Going to tweak the method names slightly, but I'll do that separately and pull this in now |
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce?
This is a feature
💥 Does this PR introduce a breaking change?
No
📝 Links to relevant issues/docs
#46
No support for View.SafeAreaLayoutGuide
🆕 What is the new behavior?
Added support to iPhone X and iOS 11 SafeArea on AdvanceFluentLayoutExtesions: AtTopOfWithSafeArea, AtLeftOfWithSafeArea, AtRightOfWithSafeArea, AtBottomOfWithSafeArea. Also this could be added to the original AtTopOf, AtLeftOf, etc, instead of the new ones.