Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the finals #44

Merged
merged 10 commits into from
Jan 28, 2024
Merged

feat: Add the finals #44

merged 10 commits into from
Jan 28, 2024

Conversation

Flowtter
Copy link
Owner

No description provided.

@Flowtter Flowtter merged commit 5fcc780 into master Jan 28, 2024
14 checks passed
@Flowtter Flowtter deleted the thefinals branch February 7, 2024 11:54
@FlutterFraz
Copy link

@Flowtter sorry if spam but I have a question: you say in the readme that in the finals there is no kill symbol, but you must already know that there is a "KILLED PLAYER" text appearing on screen on every kill (and every action-on-objective) so I was wondering what was the problem in implementing this feature?
Thanks for the work by the way!

@Flowtter
Copy link
Owner Author

Flowtter commented Jul 3, 2024

The KILLED PLAYER text only appears if you have the game in English, and it's also quite a long "symbol", so asking crispy to look for it would be more time-consuming and less effective than the current solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants