Rebuild rolescopepicker #5580
Rebuild rolescopepicker #5580
Conversation
Thanks to Stef for asking the right question
Thingus
added
FlowAuth
| // label={"Scopes"} | ||
| /> | ||
| ); | ||
| // This mess takes every scope that is |
There was a problem hiding this comment.
Easier to just return that form from the backend?
There was a problem hiding this comment.
It needs both fully-resolved scope paths and the grouped rep; it'd need to be mangling whatever's returned in one direction or the other.
|
|
||
| }) |
There was a problem hiding this comment.
No newline?! 😱
I thought the code formatter takes care of these things?
There was a problem hiding this comment.
Knew I'd forgotten to do something...
| @@ -2,109 +2,227 @@ | |||
| * License, v. 2.0. If a copy of the MPL was not distributed with this | |||
| * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | |||
|
|
|||
| /* eslint-disable react/prop-types */ | |||
There was a problem hiding this comment.
What happens if we don't disable this?
If it really makes no sense perhaps we can disable in eslint's config globally?
There was a problem hiding this comment.
It's something we should be doing (according to eslint), but haven't - I'd like to put it in in future, but I think it adds a dependency.
I have:
masterpermission_reworkDescription
This re-implements
RoleScopePicker, reimplementingCascadePickerwithin Flowauth. There is also a Cypress component test.Note: This does not use any of
util.js, bututil.jsis still used byRightsCascade, inServerAdmin.jsx.