Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Allow AWS SECRETS MANAGER instead of storing AES Encrypted in db #3616

Merged
merged 10 commits into from
Jan 8, 2025

Conversation

aluferraz
Copy link
Contributor

@aluferraz aluferraz commented Dec 1, 2024

This pull request introduces a significant security enhancement by providing an option to migrate away from storing AES-encrypted sensitive data directly in our database. Instead, it allows us to leverage AWS Secrets Manager to securely store, manage, and retrieve our application's secrets.

Key Highlights of this Change:

Improved Security: Sensitive data is now protected by AWS Secrets Manager's enterprise-grade security features, including encryption at rest and in transit, strict access controls, and auditing capabilities.
Compliance Alignment: This shift enhances our alignment with various regulatory compliance standards that recommend or mandate the use of dedicated secret management solutions for sensitive data.
Simplified Key Management: No longer will we need to manage AES encryption keys within our application, reducing operational overhead and potential security risks associated with key mismanagement.
Audit Trail: Traceble log of credentials

image image

@aluferraz
Copy link
Contributor Author

@HenryHengZJ any thoughts on this feature ? It can be toggled using env. vars.

# Conflicts:
#	packages/components/src/utils.ts
#	packages/server/src/commands/start.ts
#	pnpm-lock.yaml
# Conflicts:
#	pnpm-lock.yaml
@HenryHengZJ
Copy link
Contributor

@aluferraz I've made some changes to the env variables naming:

To use aws:

SECRETKEY_STORAGE_TYPE=aws#(local | aws)
SECRETKEY_AWS_ACCESS_KEY=<your-access-key>
SECRETKEY_AWS_SECRET_KEY=<your-secret-key>
SECRETKEY_AWS_REGION=us-west-2

@aluferraz
Copy link
Contributor Author

aluferraz commented Jan 8, 2025

Thanks a lot @HenryHengZJ, I'm happy to continue contributing, are we missing anything after your updates or are we good to merge?

@HenryHengZJ
Copy link
Contributor

we're good to merge! thank you @aluferraz !

@HenryHengZJ HenryHengZJ merged commit 1ae78c2 into FlowiseAI:main Jan 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants