-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Allow AWS SECRETS MANAGER instead of storing AES Encrypted in db #3616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@HenryHengZJ any thoughts on this feature ? It can be toggled using env. vars. |
HenryHengZJ
reviewed
Dec 4, 2024
HenryHengZJ
reviewed
Dec 4, 2024
# Conflicts: # packages/components/src/utils.ts # packages/server/src/commands/start.ts # pnpm-lock.yaml
# Conflicts: # pnpm-lock.yaml
@aluferraz I've made some changes to the env variables naming: To use aws:
|
Thanks a lot @HenryHengZJ, I'm happy to continue contributing, are we missing anything after your updates or are we good to merge? |
HenryHengZJ
approved these changes
Jan 8, 2025
we're good to merge! thank you @aluferraz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a significant security enhancement by providing an option to migrate away from storing AES-encrypted sensitive data directly in our database. Instead, it allows us to leverage AWS Secrets Manager to securely store, manage, and retrieve our application's secrets.
Key Highlights of this Change:
Improved Security: Sensitive data is now protected by AWS Secrets Manager's enterprise-grade security features, including encryption at rest and in transit, strict access controls, and auditing capabilities.
Compliance Alignment: This shift enhances our alignment with various regulatory compliance standards that recommend or mandate the use of dedicated secret management solutions for sensitive data.
Simplified Key Management: No longer will we need to manage AES encryption keys within our application, reducing operational overhead and potential security risks associated with key mismanagement.
Audit Trail: Traceble log of credentials