Bugfix/Concurrent Chat Session #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix: Change agent/chain to use RunnableSequence, this allow us to retrieve memory during runtime when |
# Conflicts: # packages/components/nodes/agents/OpenAIFunctionAgent/OpenAIFunctionAgent.ts
JohnBQuinn
pushed a commit
to JohnBQuinn/Flowise
that referenced
this pull request
Jun 7, 2024
* perf: read rawText and chunk code * perf: read raw text * perf: read rawtext * perf: token count * log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: when concurrent users are chatting with a flow, memory is mixed up:
Steps to reproduce:
1.) Have a simple conversation chain and memory with sessionId:
2.) Open the chat, and introduce your name as “Evan”
3.) Open the Share Chatbot (to imitate another session), and introduce yourself as “Henry”
4.) Now, here’s the importance step. Prepare the question in the chatbox first:
Henry’s session
Evan’s session
Then from the Share Chatbot (Henry’s session) page, quickly press enter to send
Switch to UI tab (Evan’s session), enter again to send
We are trying to simulate concurrent request
5.) Go to Redis Insight, observe the session:
Henry’s session
Evan’s session:
as you can see, Henry’s session messages got saved into Evan’s. Why? Because UI (Evan’s) is where I last entered “whats my name”