[Bug] Fix Cannot read properties of undefined (reading 'replace') #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chz8494
changed the title
|
thanks for the suggested fix! Can you let me know how to replicate the issue? I've been trying to use the Conversational Retrieval QA Chain template, but mine works everytime |
|
For example, if you have an empty confluence page, the document results will end up with undefined pagecontent and some metadata. Also if you drag a confluence loader as document input then replace it with other loader, it also end up with undefined pagecontent with a confluence element in the document array. |
|
@chz8494 do you have any other examples? I was not able to have Confluence setup correctly |
HenryHengZJ
reviewed
Oct 27, 2023
|
I’ll change that in my PR. My actual fix was supposed to be just "if (flattenDocs[i].pageContent !== undefined)" but had put it only flattenDocs[i] accidentally. |
hemati
pushed a commit
to hemati/Flowise
that referenced
this pull request
Dec 27, 2023
[Bug] Fix Cannot read properties of undefined (reading 'replace')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
undefined document pagecontent is causing reading issue with replace function.
fix for:
#1106 #1123