-
-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #911, CRLF line endings on Linux scripts. #1054
Conversation
awesome thanks @automaton82 for the fix! |
do you mind pulling latest changes from main branch to get the Node CI pass? |
Sure I did a sync just now. Hopefully that solves it. |
I think they passed now, so it seems to have worked. |
Looks like a permissions issue on the file when in docker. But the permissions don't come from the host machine, so I'm not sure how it could be related. That's odd. |
Yeah, merged the revert PR and it fixed the issue. Not sure what was the cause of it |
Ok. I'll try to replicate. The way it is now won't docker run in Windows, so there must be a way to fix both. |
@HenryHengZJ I think I can fix this by following https://stackoverflow.com/questions/30195151/can-i-commit-specific-files-in-git-without-affecting-the-original-line-ending and adding a I have this working locally in Windows, but I'm now going to test it on Ubuntu WSL2 Linux. If it passes both of these, are you okay if I submit another PR with this file added to solve this instead of the failed way? |
Well I submitted a new PR #1077 which I tested to ensure it would run on Linux and Windows. It's a 1 file addition for git to deal with the line endings, and no changes to the actual files to avoid any permissions issues again. Hopefully this is ok. It does fix it, as long as the file is touched by git (or re-cloned). |
Fix for FlowiseAI#911, CRLF line endings on Linux scripts.
As per #911, the line endings on the Linux scripts are CRLF which do not work properly if a Docker build is created on Windows. To solve this, the line endings are converted to LF in source.