Skip to content

Commit

Permalink
Pin the [email protected]
Browse files Browse the repository at this point in the history
  • Loading branch information
@ocflowiseai
ocflowiseai authored Apr 16, 2024
1 parent 5b0941e commit d07bd96
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ RUN apk add --no-cache build-base cairo-dev pango-dev
RUN apk add --no-cache chromium

#install PNPM globaly
RUN npm install -g pnpm
RUN npm install -g pnpm@8.14.0

ENV PUPPETEER_SKIP_DOWNLOAD=true
ENV PUPPETEER_EXECUTABLE_PATH=/usr/bin/chromium-browser
Expand Down

7 comments on commit d07bd96

@automaton82
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option (and perhaps a better one) is to change package.json this line:
"packageManager": "[email protected]",

Set it to 9.0.1 instead. Otherwise this only fixes Docker, but no other deployment methods. For example, render.com uses 9.0.1 so if deployed as node it will still fail cc @HenryHengZJ

@automaton82
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if package manager version can be ^ instead, which would be even better.

@ocflowiseai
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option (and perhaps a better one) is to change package.json this line: "packageManager": "[email protected]",

Set it to 9.0.1 instead. Otherwise this only fixes Docker, but no other deployment methods. For example, render.com uses 9.0.1 so if deployed as node it will still fail cc @HenryHengZJ

Not sure if package manager version can be ^ instead, which would be even better.

The field packageManager doesn't support the ^. Opened a PR here to address your concerns. Thank you for your suggestion!

@automaton82
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!

@HenryHengZJ
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deployed using node on render, seeing this error:
image

works fine on local machine

@automaton82
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Henry, I just cloned the repo fresh and tried and it worked for me:

image

image

It's possible a package was broken when you tried it. Also when you deploy try a new instance, or if you use Manual Deploy try the clear cache one.

@HenryHengZJ
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, cleaning cache works!

Please sign in to comment.