Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #109 #110

Closed
wants to merge 1 commit into from
Closed

fix: #109 #110

wants to merge 1 commit into from

Conversation

deyaeddin
Copy link

No description provided.

Copy link

sonarcloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@javier-godoy
Copy link
Member

LazyDataView.getItems().toList() is an expensive operation, because it retrieves the full data available to the component. If lazy data providers are being used, I think that https://github.com/vaadin-component-factory/selection-grid-flow provides a better approach.

@javier-godoy
Copy link
Member

As explained above, this approach will have performance issues if the backend query returns a lot of items. Implementing support for lazy data providers requires that the client side provides the row indexes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants