Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky tests #2642

Open
1 task
DenBond7 opened this issue Mar 17, 2024 · 3 comments
Open
1 task

Fix flaky tests #2642

DenBond7 opened this issue Mar 17, 2024 · 3 comments
Assignees
@DenBond7
Labels
android_testing This label means we need to add an Android test.
Milestone
1.6.1: Conversati...

Comments

@DenBond7
Copy link
Collaborator

DenBond7 commented Mar 17, 2024 •
edited
Loading

  • FeedbackFragmentHasAccountInIsolationTest.testUserEmailVisibility()
@DenBond7 DenBond7 added the android_testing This label means we need to add an Android test. label Mar 17, 2024
@DenBond7 DenBond7 added this to the 1.5.5 milestone Mar 17, 2024
@DenBond7 DenBond7 self-assigned this Mar 17, 2024
This was referenced Mar 17, 2024
Merged
Merged
@DenBond7 DenBond7 modified the milestones: 1.5.5, 1.5.6 Mar 26, 2024
DenBond7 added a commit that referenced this issue May 16, 2024
@DenBond7
Disabled debugging for some scripts.| #2642
bc76e80
DenBond7 added a commit that referenced this issue May 16, 2024
@DenBond7
Modified some test filters. Added ReadyForCIAndNonFlakyFilter.| #2642
342cc9c
DenBond7 added a commit that referenced this issue May 16, 2024
@DenBond7
Marked some disabled flaky tests as flaky.| #2642
ecc01cb
DenBond7 added a commit that referenced this issue May 16, 2024
@DenBond7
Fixed some flaky tests.| #2642
94af3f7
@DenBond7 DenBond7 mentioned this issue May 16, 2024
Merged
4 tasks
sosnovsky pushed a commit that referenced this issue May 16, 2024
@DenBond7
Fixed some flaky tests (#2721)
b9a0d41 
* Disabled debugging for some scripts.| #2642

* Modified some test filters. Added ReadyForCIAndNonFlakyFilter.| #2642

* Marked some disabled flaky tests as flaky.| #2642

* Fixed some flaky tests.| #2642
@DenBond7 DenBond7 modified the milestones: 1.5.6, 1.5.7 May 17, 2024
DenBond7 added a commit that referenced this issue May 17, 2024
@DenBond7
Added ReadyForCIAndFlakyFilter.| #2642
a4b152e
DenBond7 added a commit that referenced this issue May 17, 2024
@DenBond7
Added a new job to semaphore.yml.| #2642
c33ce88
@DenBond7 DenBond7 mentioned this issue May 17, 2024
Merged
4 tasks
sosnovsky pushed a commit that referenced this issue May 20, 2024
@DenBond7
added a new job to semaphore CI for flaky tests (#2722)
e58d040 
* Added ReadyForCIAndFlakyFilter.| #2642

* Added a new job to semaphore.yml.| #2642

* wip

* wip

* wip
@DenBond7
Copy link
Collaborator Author

https://flowcrypt.semaphoreci.com/jobs/2f3e6681-e09d-4b39-822b-3d58841b7b44

@DenBond7
Copy link
Collaborator Author

Some details for history.

We have some flaky tests that depend on an emulator(emulator performance).

For example, on the server, we see the following in the logs
Boot completed in 57836 ms

But on my machine I see the following
Boot completed in 24322 ms

It means on my machine an emulator works much faster. And that's why I usually can't reproduce some flaky tests.
Unfortunately, I can't use for example virtual box to create a slower machine. Because the Android emulator requires virtualization. And the nested virtualization doesn't work well.

But I've found a way. I bought a small and not fast tiny PC like this one

image

Now I can reproduce most flaky tests.

@DenBond7 DenBond7 modified the milestones: 1.5.7, 1.5.8 May 30, 2024
@sosnovsky
Copy link
Collaborator

Oh, it was a radical solution, great that it works 👍

@DenBond7 DenBond7 mentioned this issue May 30, 2024
Merged
4 tasks
@DenBond7 DenBond7 modified the milestones: 1.5.8, 1.5.9 Jul 3, 2024
@DenBond7 DenBond7 removed this from the 1.6.0 milestone Aug 7, 2024
@DenBond7 DenBond7 added this to the 1.6.1: Conversation view milestone Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DenBond7 DenBond7

Labels
android_testing This label means we need to add an Android test.
Projects
None yet
Milestone
1.6.1: Conversation view
Development

No branches or pull requests
2 participants
@sosnovsky @DenBond7