Global browser setting / Private mode option

Flow.Launcher.Infrastructure/UserSettings/CustomBrowserViewModel.cs

@@ -0,0 +1,33 @@
+using Flow.Launcher.Plugin;
+using System.Text.Json.Serialization;
+
+namespace Flow.Launcher.Infrastructure.UserSettings
+{
+    public class CustomBrowserViewModel : BaseModel
+    {
+        public string Name { get; set; }
+        public string Path { get; set; }
+        public string PrivateArg { get; set; }
+        public bool EnablePrivate { get; set; }
+        public bool OpenInTab { get; set; } = true;
+        [JsonIgnore]
+        public bool OpenInNewWindow => !OpenInTab;
+        public bool Editable { get; set; } = true;
+
+        public CustomBrowserViewModel Copy()
+        {
+            return new CustomBrowserViewModel
+            {
+                Name = Name,
+                Path = Path,
+                OpenInTab = OpenInTab,
+                PrivateArg = PrivateArg,
+                EnablePrivate = EnablePrivate,
+                Editable = Editable
+            };
+        }
+    }
+}
+
+
+

Flow.Launcher.Infrastructure/UserSettings/Settings.cs

@@ -39,6 +39,8 @@ public string Language
         public string ResultFontWeight { get; set; }
         public string ResultFontStretch { get; set; }
         public bool UseGlyphIcons { get; set; } = true;
+        public bool UseAnimation { get; set; } = true;
+        public bool UseSound { get; set; } = true;
         public bool FirstLaunch { get; set; } = true;
 
         public int CustomExplorerIndex { get; set; } = 0;
@@ -84,8 +86,52 @@ public CustomExplorerViewModel CustomExplorer
             }
         };
 
-        public bool UseAnimation { get; set; } = true;
-        public bool UseSound { get; set; } = true;
+        public int CustomBrowserIndex { get; set; } = 0;
+
+        [JsonIgnore]
+        public CustomBrowserViewModel CustomBrowser
+        {
+            get => CustomBrowserList[CustomBrowserIndex];
+            set => CustomBrowserList[CustomBrowserIndex] = value;
+        }
+
+        public List<CustomBrowserViewModel> CustomBrowserList { get; set; } = new()
+        {
+            new()
+            {
+                Name = "Default",
+                Path = "*",
+                PrivateArg = "",
+                EnablePrivate = false,
+                Editable = false
+            },
+            new()
+            {
+                Name = "Google Chrome",
+                Path = "chrome",
+                PrivateArg = "-incognito",
+                EnablePrivate = false,
+                Editable = false
+            },
+            new()
+            {
+                Name = "Mozilla Firefox",
+                Path = "firefox",
+                PrivateArg = "-private",
+                EnablePrivate = false,
+                Editable = false
+            }
+            ,
+            new()
+            {
+                Name = "MS Edge",
+                Path = "msedge",
+                PrivateArg = "-inPrivate",
+                EnablePrivate = false,
+                Editable = false
+            }
+        };
+
 
         /// <summary>
         /// when false Alphabet static service will always return empty results

Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs

@@ -212,5 +212,10 @@ public interface IPublicAPI
         /// <param name="DirectoryPath">Directory Path to open</param>
         /// <param name="FileName">Extra FileName Info</param>
         public void OpenDirectory(string DirectoryPath, string FileName = null);
+
+        /// <summary>
+        /// Open Url in the configured default browser for Flow's Settings.
+        /// </summary>
+        public void OpenUrl(string url, bool? inPrivate = null);
     }
 }

Flow.Launcher.Plugin/SharedCommands/SearchWeb.cs

@@ -35,18 +35,21 @@ private static string GetDefaultBrowserPath()
         /// Opens search in a new browser. If no browser path is passed in then Chrome is used. 
         /// Leave browser path blank to use Chrome.
         /// </summary>
-		public static void NewBrowserWindow(this string url, string browserPath = "")
+        public static void OpenInBrowserWindow(this string url, string browserPath = "", bool inPrivate = false, string privateArg = "")
         {
             browserPath = string.IsNullOrEmpty(browserPath) ? GetDefaultBrowserPath() : browserPath;
 
             var browserExecutableName = browserPath?
-                                        .Split(new[] { Path.DirectorySeparatorChar }, StringSplitOptions.None)
-                                        .Last();
+                .Split(new[]
+                {
+                    Path.DirectorySeparatorChar
+                }, StringSplitOptions.None)
+                .Last();
 
             var browser = string.IsNullOrEmpty(browserExecutableName) ? "chrome" : browserPath;
 
             // Internet Explorer will open url in new browser window, and does not take the --new-window parameter
-            var browserArguements = browserExecutableName == "iexplore.exe" ? url : "--new-window " + url;
+            var browserArguements = (browserExecutableName == "iexplore.exe" ? "" : "--new-window ") + (inPrivate ? $"{privateArg} " : "") + url;
 
             var psi = new ProcessStartInfo
             {
@@ -61,24 +64,36 @@ public static void NewBrowserWindow(this string url, string browserPath = "")
             }
             catch (System.ComponentModel.Win32Exception)
             {
-                Process.Start(new ProcessStartInfo { FileName = url, UseShellExecute = true });
+                Process.Start(new ProcessStartInfo
+                {
+                    FileName = url, UseShellExecute = true
+                });
             }
         }
 
+        [Obsolete("This is provided for backwards compatibility after 1.9.0 release, e.g. GitHub plugin. Use the new method instead")]
+        public static void NewBrowserWindow(this string url, string browserPath = "")
+        {
+            OpenInBrowserWindow(url, browserPath);
+        }
+
         /// <summary> 
         /// Opens search as a tab in the default browser chosen in Windows settings.
         /// </summary>
-        public static void NewTabInBrowser(this string url, string browserPath = "")
+        public static void OpenInBrowserTab(this string url, string browserPath = "", bool inPrivate = false, string privateArg = "")
         {
             browserPath = string.IsNullOrEmpty(browserPath) ? GetDefaultBrowserPath() : browserPath;
 
-            var psi = new ProcessStartInfo() { UseShellExecute = true };
+            var psi = new ProcessStartInfo()
+            {
+                UseShellExecute = true
+            };
             try
             {
                 if (!string.IsNullOrEmpty(browserPath))
                 {
                     psi.FileName = browserPath;
-                    psi.Arguments = url;
+                    psi.Arguments = (inPrivate ? $"{privateArg} " : "") + url;
                 }
                 else
                 {
@@ -90,8 +105,17 @@ public static void NewTabInBrowser(this string url, string browserPath = "")
             // This error may be thrown if browser path is incorrect
             catch (System.ComponentModel.Win32Exception)
             {
-                Process.Start(new ProcessStartInfo { FileName = url, UseShellExecute = true });
+                Process.Start(new ProcessStartInfo
+                {
+                    FileName = url, UseShellExecute = true
+                });
             }
         }
+
+        [Obsolete("This is provided for backwards compatibility after 1.9.0 release, e.g. GitHub plugin. Use the new method instead")]
+        public static void NewTabInBrowser(this string url, string browserPath = "")
+        {
+            OpenInBrowserTab(url, browserPath);
+        }
     }
-}
+}

Flow.Launcher/Languages/en.xaml

@@ -38,6 +38,8 @@
     <system:String x:Key="ignoreHotkeysOnFullscreenToolTip">Disable Flow Launcher activation when a full screen application is active (Recommended for games).</system:String>
     <system:String x:Key="defaultFileManager">Default File Manager</system:String>
     <system:String x:Key="defaultFileManagerToolTip">Select the file manager to use when opening the folder.</system:String>
+    <system:String x:Key="defaultBrowser">Default Web Browser</system:String>
+    <system:String x:Key="defaultBrowserToolTip">Setting for New Tab, New Window, Private Mode.</system:String>
     <system:String x:Key="pythonDirectory">Python Directory</system:String>
     <system:String x:Key="autoUpdates">Auto Update</system:String>
     <system:String x:Key="selectPythonDirectory">Select</system:String>
@@ -164,6 +166,16 @@
     <system:String x:Key="fileManager_directory_arg">Arg For Folder</system:String>
     <system:String x:Key="fileManager_file_arg">Arg For File</system:String>
 
+    <!--  DefaultBrowser Setting Dialog  -->
+    <system:String x:Key="defaultBrowserTitle">Default Web Browser</system:String>
+    <system:String x:Key="defaultBrowser_tips">The default setting follows the OS default browser setting. If specified separately, flow uses that browser.</system:String>
+    <system:String x:Key="defaultBrowser_name">Browser</system:String>
+    <system:String x:Key="defaultBrowser_profile_name">Browser Name</system:String>
+    <system:String x:Key="defaultBrowser_path">Browser Path</system:String>
+    <system:String x:Key="defaultBrowser_newtab">New Window</system:String>
+    <system:String x:Key="defaultBrowser_newWindow">New Tab</system:String>
+    <system:String x:Key="defaultBrowser_parameter">Priviate Mode</system:String>
+
     <!--  Priority Setting Dialog  -->
     <system:String x:Key="changePriorityWindow">Change Priority</system:String>
     <system:String x:Key="priority_tips">Greater the number, the higher the result will be ranked. Try setting it as 5. If you want the results to be lower than any other plugin's, provide a negative number</system:String>

Flow.Launcher/PublicAPIInstance.cs

@@ -114,7 +114,7 @@ public void ShellRun(string cmd, string filename = "cmd.exe")
             var startInfo = ShellCommand.SetProcessStartInfo(filename, arguments: args, createNoWindow: true);
             ShellCommand.Execute(startInfo);
         }
-        
+
         public void CopyToClipboard(string text)
         {
             Clipboard.SetDataObject(text);
@@ -196,7 +196,7 @@ public void SavePluginSettings()
 
         public void OpenDirectory(string DirectoryPath, string FileName = null)
         {
-            using Process explorer = new Process();
+            using var explorer = new Process();
             var explorerInfo = _settingsVM.Settings.CustomExplorer;
             explorer.StartInfo = new ProcessStartInfo
             {
@@ -209,6 +209,23 @@ public void OpenDirectory(string DirectoryPath, string FileName = null)
             explorer.Start();
         }
 
+        public void OpenUrl(string url, bool? inPrivate = null)
+        {
+            var browserInfo = _settingsVM.Settings.CustomBrowser;
+
+            var path = browserInfo.Path == "*" ? "" : browserInfo.Path;
+
+            if (browserInfo.OpenInTab)
+            {
+                url.OpenInBrowserTab(path, inPrivate ?? browserInfo.EnablePrivate, browserInfo.PrivateArg);
+            }
+            else
+            {
+                url.OpenInBrowserWindow(path, inPrivate ?? browserInfo.EnablePrivate, browserInfo.PrivateArg);
+            }
+
+        }
+
         public event FlowLauncherGlobalKeyboardEventHandler GlobalKeyboardEvent;
 
         #endregion