Skip to content

Conversation

@taooceros
Copy link
Member

@taooceros taooceros commented Oct 30, 2021

Add OnCultureInfoChanged to IPublicI18n to allow plugin do action when change language.

It is added with default implementation for interface for backward compatibility (so optional).

@taooceros taooceros changed the title Add OnCultureInfoChanged to IPluginI18n to allow plugin do action whe… Add OnCultureInfoChanged to IPluginI18n Oct 30, 2021
@taooceros taooceros requested review from jjw24 and pc223 October 30, 2021 03:18
@taooceros
Copy link
Member Author

With the commit, the windowssetting plugin is truly internationalized.

@taooceros taooceros self-assigned this Oct 30, 2021
@onesounds
Copy link
Contributor

It was confirmed that the function worked well in Korean language.

@jjw24 jjw24 added the enhancement New feature or request label Nov 2, 2021
@jjw24 jjw24 added this to the 1.9.0 milestone Nov 2, 2021
@jjw24 jjw24 merged commit d0ceea0 into add_windows_settings_plugin Nov 2, 2021
@jjw24 jjw24 deleted the translation_new_api branch November 2, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants