-
-
Notifications
You must be signed in to change notification settings - Fork 457
Modern Themes #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modern Themes #704
Changes from 1 commit
3a0594f
0c47557
b07a437
7789c1c
c6f1a00
53c04fd
f07a009
4ced995
f83212a
c227ba3
3bc3563
46917ea
3e25030
91d21a7
505b4cb
8eba28f
f1bfa5c
9d10b7f
bb7b0cd
ecb0cac
6a58576
136f227
c89d277
49f00f5
8e93969
6048de4
6211275
c32ae79
2b7855c
39b53d9
2144577
03d134d
6e047e0
e7b4dd1
df3c5bf
89f4f5d
1621f34
92f0041
c1b0929
832405a
1c96f04
ca179be
ed5bd5b
4e01019
d084793
e201df9
6c43a48
a5534ca
d1e7b4e
1948ec5
88a9767
10accd5
d902a1e
e14bb23
1b1a81d
12f95d1
25b5f30
8aaeb85
66e722b
1149ff5
c74a2db
763cab8
54145d7
5f0df98
04a10ed
4f19355
1d746c2
42dda34
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -207,9 +207,9 @@ private void InitializeNotifyIcon() | |
|
|
||
| private void InitProgressbarAnimation() | ||
| { | ||
| var da = new DoubleAnimation(ProgressBar.X2, ActualWidth + 100, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I would think getting the ActualWidth is so it's dynamically adjusted for the toValue in the method. What was the issue with using ActualWidth? Problem with putting in 900 is that the next person is not going to understand why 900 was chosen.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's because the animation has to go outside window. Anyway, it was fixed to add +100 to the actual width.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah and i dont understand why add 100 lol, magic number
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
if you are reverting back to using ActualWidth, will it erase this improvement you mentioned about the color and noticeability of the progress animation?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. da1's 100 number is progressbar width size. (it is not gauge.) it will move left to right actual window size.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sry, No. it's not moving properly. I'll look a bit more. |
||
| var da = new DoubleAnimation(ProgressBar.X2, ActualWidth + 150, | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Finally Progress bar fixed. I think it's my last push in this branch. I'll do something other branch. The fixed Width size was the problem. I mistook activewidth for window size. Adjust |
||
| new Duration(new TimeSpan(0, 0, 0, 0, 1600))); | ||
| var da1 = new DoubleAnimation(ProgressBar.X1, ActualWidth, new Duration(new TimeSpan(0, 0, 0, 0, 1600))); | ||
| var da1 = new DoubleAnimation(ProgressBar.X1, ActualWidth + 50, new Duration(new TimeSpan(0, 0, 0, 0, 1600))); | ||
| Storyboard.SetTargetProperty(da, new PropertyPath("(Line.X2)")); | ||
| Storyboard.SetTargetProperty(da1, new PropertyPath("(Line.X1)")); | ||
| _progressBarStoryboard.Children.Add(da); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the height cannot be given, a rectangle was used instead of a separator.