Implement Requery option and requery when calling customQueryHotkey #702
Conversation
jjw24
added
enhancement
|
@taooceros have you tested this sovles the issue 701? I remember the requery doesnt work from the context menu, do you know if this also addresses it? |
Hmm I don't think so |
| { | ||
| QueryText = queryText; | ||
| } | ||
| else if (reQuery) |
There was a problem hiding this comment.
I feel like this shouldnt be an 'else if', they should be two seperate statements
There was a problem hiding this comment.
Well actually, when QueryText is not equal to queryText, the requery will be triggered. Only when they are the same, we need manually requery.
There was a problem hiding this comment.
ohhh it's requeried in the setter method...
There was a problem hiding this comment.
lets add a comment in to make it clear
There was a problem hiding this comment.
I remember it is the optimization from fody xd
jjw24
added
the
review in progress
|
the vscode online makes these kinds of quick commit much easier lol |
jjw24
removed
the
review in progress
|
i keep forgetting to use vscode online lol |
resolves #701