Skip to content

Enable TwoWay binding for MaxSuggestions NumberBox #4279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jack251970 merged 2 commits into from
Feb 24, 2026
Merged

Enable TwoWay binding for MaxSuggestions NumberBox #4279

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72269db
Enable TwoWay binding for MaxSuggestions NumberBox
Jack251970 Feb 23, 2026
c9baab7
Merge branch 'dev' into websearch_ui
Jack251970 Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Plugins/Flow.Launcher.Plugin.WebSearch/SettingsControl.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
xmlns:ikw="http://schemas.inkore.net/lib/ui/wpf"

Check warning on line 6 in Plugins/Flow.Launcher.Plugin.WebSearch/SettingsControl.xaml

View workflow job for this annotation

GitHub Actions / Check Spelling 

`ikw` is not a recognized word. (unrecognized-spelling)
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
xmlns:ui="http://schemas.inkore.net/lib/ui/wpf/modern"
xmlns:vm="clr-namespace:Flow.Launcher.Plugin.WebSearch"
Expand Down Expand Up @@ -61,7 +61,7 @@
Style="{StaticResource {x:Static GridView.GridViewStyleKey}}">
<ListView.View>
<GridView>
<!-- Margin="0 4" is a workaround to set this TextBlock to vertially center -->

Check warning on line 64 in Plugins/Flow.Launcher.Plugin.WebSearch/SettingsControl.xaml

View workflow job for this annotation

GitHub Actions / Check Spelling 

`vertially` is not a recognized word. (unrecognized-spelling)
<GridViewColumn Width="45">
<GridViewColumn.CellTemplate>
<DataTemplate>
Expand All @@ -74,7 +74,7 @@
</GridViewColumn.CellTemplate>
</GridViewColumn>

<!-- Margin="0 6" is a workaround to set this TextBlock to vertially center -->

Check warning on line 77 in Plugins/Flow.Launcher.Plugin.WebSearch/SettingsControl.xaml

View workflow job for this annotation

GitHub Actions / Check Spelling 

`vertially` is not a recognized word. (unrecognized-spelling)

Check warning on line 77 in Plugins/Flow.Launcher.Plugin.WebSearch/SettingsControl.xaml

View workflow job for this annotation

GitHub Actions / Check Spelling 

`vertially` is not a recognized word. (unrecognized-spelling)
<GridViewColumn Width="135" Header="{DynamicResource flowlauncher_plugin_websearch_action_keyword}">
<GridViewColumn.CellTemplate>
<DataTemplate>
Expand Down Expand Up @@ -108,7 +108,7 @@
</GridViewColumn.CellTemplate>
</GridViewColumn>

<!-- CheckBox is vertially center by default -->

Check warning on line 111 in Plugins/Flow.Launcher.Plugin.WebSearch/SettingsControl.xaml

View workflow job for this annotation

GitHub Actions / Check Spelling 

`vertially` is not a recognized word. (unrecognized-spelling)

Check warning on line 111 in Plugins/Flow.Launcher.Plugin.WebSearch/SettingsControl.xaml

View workflow job for this annotation

GitHub Actions / Check Spelling 

`vertially` is not a recognized word. (unrecognized-spelling)
<GridViewColumn Width="123" Header="{DynamicResource flowlauncher_plugin_websearch_private_mode_label}">
<GridViewColumn.CellTemplate>
<DataTemplate>
Expand Down Expand Up @@ -164,7 +164,7 @@
SpinButtonPlacementMode="Compact"
ValidationMode="InvalidInputOverwritten"
ValueChanged="NumberBox_ValueChanged"
Value="{Binding Settings.MaxSuggestions, Mode=OneWay}" />
Value="{Binding Settings.MaxSuggestions, Mode=TwoWay}" />
</StackPanel>
<CheckBox
Name="EnableSuggestion"
Expand Down
Loading