Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Search Manager #1832

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

Refactor Search Manager #1832

wants to merge 4 commits into from

Conversation

taooceros
Copy link
Member

@taooceros taooceros commented Jan 23, 2023

  1. Greatly Refactor ActionKeyword Match with Flags to avoid tedious check
  2. Return SearchResult instead of Result (and cast outside)
  3. Make PathSearch return IAsyncEnumerable (instead of plain result)
  4. Use Iterator for Environmental Path Search

Tested:

  • ActionKeyword works
  • Environmental Path Search works
  • Create Current Result Works
  • Path can be searched

1. Return SearchResult instead of Result (and cast outside)
2. Make PathSearch return IAsyncEnumerable (instead of plain result)
3. Use Iterator for Environmental Path Search
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Jan 23, 2023

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (24)
APartial
APath
basepath
bla
blabla
CSearch
drv
FREETEXT
hashcode
homedrive
homepath
ignorecase
mok
NUnit
openresultfolder
sln
somefile
somefolder
someotherfolder
splited
subfolders
systemdrive
temppath
totalspace
To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:Flow-Launcher/Flow.Launcher.git repository
on the refactor_explorer_search branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/3988874620/attempts/1'

To have the bot do this for you, reply quoting the following line:
@check-spelling-bot apply updates.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant