Skip to content
This repository has been archived by the owner on May 31, 2021. It is now read-only.

WIP: Handle faults returned from rtorrent #841

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

wheelerlaw
Copy link

Description

When rtorrent encounters an error interacting with the xmlrpc interface, it will return a response with a <fault>...</fault> tag in the response body. Currently Flood doesn't handle this tag in the rtorrentDeserializer.

Related Issue

#840

Motivation and Context

Flood doesn't display the original error returned back from rtorrent, and any useful context that the original error message may provide is lost.

How Has This Been Tested?

Haven't tested it yet, just proposing changes.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@wheelerlaw wheelerlaw changed the title Handle faults returned from rtorrent WIP: Handle faults returned from rtorrent Sep 26, 2019
@wheelerlaw
Copy link
Author

So with the changes, the original error message makes it back to the client, but I still need to build in some functionality into the add files modal to handle errors from the server.

jfurrow
jfurrow previously approved these changes Oct 19, 2019
Copy link
Member

@jfurrow jfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@jfurrow
Copy link
Member

jfurrow commented Oct 19, 2019

Oh I just realized you're planning to add on to this, I'll dismiss my approval

@damolp
Copy link
Contributor

damolp commented Jan 29, 2020

Any idea what happened before ccf4688 ? did it just swallow the error as well?

jesec pushed a commit to jesec/flood that referenced this pull request Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants