Add preparing state to sheet view. #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that isSheetShowing() returns true while we are still laying out the sheet. Before this showWithSheetView() could break even though isSheetShowing() returned false.
|
LGTM |
|
I don't have push access. You will have to push the green button yourself :) |
ZacSweers
added a commit
that referenced
this pull request
Aug 21, 2015
Add preparing state to sheet view.
|
That's not right... I'll talk to matt tomorrow, you should still have push access. |
|
Goldengate as well in that case :p |
|
All set; check your email @emilsjolander. |
|
Thanks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that isSheetShowing() returns true while we are still laying out the sheet. Before this showWithSheetView() could break even though isSheetShowing() returned false.
Fixes #48