Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify the violation report location in regex #3

Closed
Jeehut opened this issue Mar 23, 2020 · 0 comments · Fixed by #32
Closed

Add option to specify the violation report location in regex #3

Jeehut opened this issue Mar 23, 2020 · 0 comments · Fixed by #32

Comments

@Jeehut
Copy link
Member

Jeehut commented Mar 23, 2020

As of now, when a regex like #"(^|\n)#[^#](.*\n)*\n#[^#]"# is specified which matches whitespaces or some kind of prefix first, where the actual problematic part lies somewhere in the middle of the matched string, the violation is still reported at the beginning of the matched string. This should be configurable, for example by providing a specific capture group name like pointer reserved for the violation location.

Also, we could consider to support multiple violating locations that are related, this way lint checks could for example point out duplicate code showing both (or all) locations of the duplicated code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant