React Compiler / React 19 #111
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tordans
force-pushed
the
react-compiler-react-19
branch
from
d2df2f5
to
a699cf0
Compare
bel7aG
reviewed
May 26, 2024
|
Did a new test today with updated packages after tailwindlabs/headlessui#3167 (comment). Results are here: 47ng/nuqs#566 (comment) |
tordans
force-pushed
the
react-compiler-react-19
branch
from
70811c7
to
04ef126
Compare
tordans
force-pushed
the
react-compiler-react-19
branch
from
04ef126
to
e58c7e4
Compare
`npx types-react-codemod@latest preset-19 ./` https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-deprecated-typescript-types And then fix the useRef type to add `undefined`
`npm install next@canary babel-plugin-react-compiler react@rc react-dom@rc types-react@rc types-react-dom@rc`
…te everything else as well `npm install @headlessui/react@insiders next@canary babel-plugin-react-compiler react@rc react-dom@rc types-react@rc types-react-dom@rc`
`npm install next@canary babel-plugin-react-compiler@latest react@rc react-dom@rc types-react@rc types-react-dom@rc nuqs@latest @headlessui/react@insiders`
`npm install next@canary babel-plugin-react-compiler@latest react@rc react-dom@rc types-react@rc types-react-dom@rc @headlessui/react@insiders` `npm i [email protected]`
Testing if things work with a full fresh npm install.
tordans
force-pushed
the
react-compiler-react-19
branch
from
e58c7e4
to
2a3c6e8
Compare
The build did not like that we imported the useMapParam file inside the middleware even though we only picked the mapParamFallback const from it. Moving the const to a separate file resolved the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Known, blocking upstream issues so far:
__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIREDtailwindlabs/headlessui#3167data-headlessui-statesupplied toReact.Fragment. React.Fragment can only havekeyandchildrenprops." tailwindlabs/headlessui#3351sourcesupplied toReact.Fragment. React.Fragment can only havekeyandchildrenprops." visgl/react-map-gl#2410