-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix: make requirement header parsing case-insensitive #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import { describe, it, expect } from 'vitest'; | ||
| import { extractRequirementsSection, parseDeltaSpec } from '../../../src/core/parsers/requirement-blocks.js'; | ||
|
|
||
| describe('extractRequirementsSection', () => { | ||
| it('parses canonical ### Requirement: headers', () => { | ||
| const result = extractRequirementsSection(`## Requirements\n### Requirement: Foo\nThe system SHALL foo.\n`); | ||
| expect(result.bodyBlocks.length).toBe(1); | ||
| expect(result.bodyBlocks[0].name).toBe('Foo'); | ||
| }); | ||
|
|
||
| it('regression: parses mixed-case ### requirement: headers without silently dropping them', () => { | ||
| const variants = [ | ||
| '### requirement: Lowercase', | ||
| '### REQUIREMENT: Uppercase', | ||
| '### Requirement: Canonical', | ||
| ]; | ||
| for (const header of variants) { | ||
| const result = extractRequirementsSection(`## Requirements\n${header}\nThe system SHALL foo.\n`); | ||
| expect(result.bodyBlocks.length).toBeGreaterThan(0); | ||
| expect(result.bodyBlocks[0].name).toBe(header.replace(/^###\s*requirement:\s*/i, '')); | ||
| } | ||
| }); | ||
|
|
||
| it('regression: parses ###Requirement: header with no space after ### without silently dropping it', () => { | ||
| const result = extractRequirementsSection(`## Requirements\n###Requirement: NoSpace\nThe system SHALL foo.\n`); | ||
| expect(result.bodyBlocks.length).toBe(1); | ||
| expect(result.bodyBlocks[0].name).toBe('NoSpace'); | ||
| }); | ||
|
|
||
| it('regression: multiple blocks where first uses no-space header are all parsed', () => { | ||
| const content = `## Requirements\n###Requirement: First\nThe system SHALL first.\n\n### Requirement: Second\nThe system SHALL second.\n`; | ||
| const result = extractRequirementsSection(content); | ||
| expect(result.bodyBlocks.length).toBe(2); | ||
| expect(result.bodyBlocks[0].name).toBe('First'); | ||
| expect(result.bodyBlocks[1].name).toBe('Second'); | ||
| }); | ||
| }); | ||
|
|
||
| describe('parseDeltaSpec', () => { | ||
| it('regression: parses ###Requirement: header with no space in delta ADDED section', () => { | ||
| const content = `## ADDED Requirements\n###Requirement: NoSpace\nThe system SHALL foo.\n`; | ||
| const result = parseDeltaSpec(content); | ||
| expect(result.added.length).toBe(1); | ||
| expect(result.added[0].name).toBe('NoSpace'); | ||
| }); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.