Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2021-2022 CARGO CONNECT season materials. #177

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zachies
Copy link

@zachies zachies commented Dec 4, 2021

Updates the default season in module.yml and adds a season file for the 2021-2022 season. The JavaScript file is missing error checking for M16 and the strings section, but it does function within the TMS software.

Copy link

@timan24 timan24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team, it's great to see this being updated as I really could have used it at our tournament yesterday. Looks like there's some logic missing on M06 as below.

if(M06_1 === 'yes' && M06_2 === 'no' && M06_3 === 'no') { return 20; } if(M06_1 === 'yes' && M06_2 === 'yes' && M06_3 === 'no') { return 30; } if(M06_1 === 'yes' && M06_2 === 'no' && M06_3 === 'yes') { return 0; } if(M06_1 === 'yes' && M06_2 === 'yes' && M06_3 === 'yes') { return 0; }
Interestingly there's also a difference between your logic on M09 and FIRSTs but I believe you're correct.

@zachies
Copy link
Author

zachies commented Dec 6, 2021

Thanks for catching that @timan24! It looks like a few of the if statements were switched around on accident, and the logic should be updated to reflect the actual scoring conditions.

@timan24
Copy link

timan24 commented Dec 6, 2021

I've confirmed with my contacts at LEGO that M09 has intentionally been left so that you can score points for latching the train but NOT have completed the train track repair.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants