-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Engine: Implement operation meta-add properly for STU3 and R4 [R4-branch] #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the entry to the Export's class internal Entry List in the case its Entry.State is equal to either EntryState.Undefined or EntryState.Internal.
This adds the entry to the Import's class internal entry list in the case its Entry.State is equal to either EntryState.Undefined or EntryState.External. This also removes the InteractionExtension Transferable() since we already make the check if the Entry has the EntryState Undefined or External before we add it the interal entry list.
This seems to only be there for some kind of documentation, but is it not needed.
Removes an unused method and a ballot comment in InteractionExtensions.
Extracted ExtractMeta() into ParametersExtensions.cs, and renamed it to ExtractMetaResources().
This adds two extension methods: - AreEqual(this Coding, Coding other) - Checks if the two Coding instances have identical System and Code. - HasEqualCoding(this IEnumerable<Coding>, Coding other) - Compares the Coding list of instances against other using the above method AreEqual() to see if they are equal.
This adds the method: - Merge(this Meta target, Meta source) - It merges the source into target.
kennethmyhra
changed the title
Engine: Implement operation meta-add properly for STU3 and R4
Engine: Implement operation meta-add properly for STU3 and R4 [R4-branch]
Apr 15, 2023
This operation was not implemented properly for FHIR versions STU3 and R4. Also it had regressed at one unknown point since now we require our resources to be internalized before they are stored to the database.
kennethmyhra
force-pushed
the
operation_meta-add
branch
from
April 15, 2023 18:03
c5b0bc8
to
288eabd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This operation was not implemented properly for FHIR versions STU3 and R4.
Also it had regressed at one unknown point since now we require our resources to be internalized before they are stored to the database.